- Added comments for some tables and #defines for clarity.
- Renamed some variables to ensure we use "color_index" instead of
"color" for palette color index related variables.
Change-Id: Ica95a26e0f171a41a3259c8e6b3b891b8cd10151
This commit makes the daala-ec work in the cb4x4 mode. As compared
to --enable-experimental, --enable-experimental --enable-cb4x4
improves the coding performance by:
lowres 2.6%
midres 1.2%
Change-Id: Ifee6f011c80364492c4a547513d24eb2958b5a56
Now that we have small number of contexts (5), use hash multipliers
(instead of base 11), so that color context hash is within a small
range. This allows us to use a lookup table to get color context
instead of a for loop.
Output bitstreams are bit-exact, so no change in compression.
Change-Id: I8cd8c893048c2fc6b22ccbd56f652d11486e2ee9
This reduces the complexity in a number of ways:
- We need just 3 neighbors instead of 4.
- Possible contexts reduce from 16 to 5.
- On hardware side, getting the contexts for a whole block will be more
parallelizable.
At the same time, compression performance improves very slightly:
- Screen-content set (videos) (Google): BDRate improved by 0.32
- screenshots set (images) (AWCY): PSNR improved by 0.62:
https://arewecompressedyet.com/?job=palette_withTR2%402017-01-27T21%3A30%3A28.890Z&job=palette_noTR2%402017-01-27T21%3A41%3A34.312Z
Change-Id: Ie84ca32f05d55ad481a51c2d3abc579468597189
This commit fixes the encoding/decoding mismatch issue when
ext-partition and ext-partition-type are both turned on in cb4x4
mode.
BUG=aomedia:336
Change-Id: I4d6ad5863c9d3bc8e3a41c259b8b39f130164790
Adjusts the value by 1 to make sure that the center tap
if the Wiener filter does not drop below 0.
BUG=aomedia:315
Change-Id: I41c3a2eb3f36dd49072a4873a995003d18f94ece
Change the list of search offsets searched when ext-partition-types
is on for square block_sizes. This is because the VERTICAL_A and
HORIZONTAL_A partitions are incompatible with the default list.
BUG=AOMEDIA:141
Change-Id: I884c45c3d11039b7dcb72336a928362f926473ed
If part of a block falls outside right and/or bottom image boundary,
then only store tokens for the part of it within the boundary.
Also, consider only the part of the block within the boundary when
calculating the number of colors in the image, deciding the base
colors for palette, RD calculation etc.
The part of color map corresponding to pixels outside the image
boundary is padded with color indices copied from same row/column.
This behavior is similar to how pixels outside the boundary are padded.
For screen_content set, this is improves compression performance by
0.038 overall. One clip, in particular, has a significant gain of 0.8.
Change-Id: I745ca032f313c5041aacc98c03ae4bfc33d840de
Creates the PVQ_SKIP_TYPE enum to encapsulate the different types of
skipping that can be signaled by PVQ (i.e. skip: AC, DC or both).
There is no impact on the bitstream. However, the decoder will now emit
an internal error if the decoded skip flag is out of range. The
block_skip variable is also renamed to ac_dc_coded as it stores the same
information.
Change-Id: Ib2aadaf99dc1736ea392ae5ed8948c3cdc12da9b
Now that https://aomedia-review.googlesource.com/#/c/6729/
has been merged, build_intra_predictors_for_interintra() is
now redundant, so replace it by a direct call to
av1_predict_intra_block() and remove the old function.
Reset rect_interintra back to 1.
To do this, we need to make the intra predictor take a
BLOCK_SIZE instead of a TX_SIZE. This is because we need to
be able to predict 32x64 and 64x32 blocks, but there is no
TX_32X64 or TX_64X32.
No effect on output or performance.
Change-Id: I8c185a211c97a85012cc54ec293c785a693608ed
Resolve the broken coding pipeline in ext-inter experiment when
cb4x4 mode is enabled. Turn off rectangular inter-intra mode.
This needs some more work to hook up. Given that it gives fairly
limited coding performance gains, disable it for the moment.
BUG=aomedia:309
Change-Id: I9b406df6183f75697bfd4eed5125a6e9436d84b0
This follows the naming for the other frame types, and allows libaom
to be compiled against other libraries that also #define NONE.
Change-Id: Ic2e2814587bbc5ea67385a9af775396d29b7dde0
* The restriction on the parameter 'delta' was too strict, so we
loosen it (delta only ever gets multiplied by -4, ... , 4,
whereas beta gets multiplied by -7, ..., 7)
* Correct a comment about the border clamping
* Fix an issue with the test case
Change-Id: I30e55203455ba6e419b5a8b646151a6d1fd5cc3b
This commit adds a new experiment, Daala's distortion function,
which is designed to better approximate perceptual distortion
in 8x8 pixel blocks.
This experiment is expected to work best with PVQ.
It measures the variance of overlapped 4x4 regions in the 8x8 area,
then uses these variances to scale the MSE of weighted frequency domain
distortion of 8x8 block.
Since AV1 calculates distortion in blocks as small as 4x4, it is not possible to
directly replace the existing distortion functions of AV1,
such as dist_block() and block_rd_txf().
Hence, there has been substantial changes in order to apply
Daala's 8x8 distortion function.
The daala distortion function is applied
after all 4x4 tx blocks in a 8x8 block are encoded (during RDO),
as in below two cases:
1) intra/inter sub8x8 predictions and
2) 4x4 transform with prediction size >= 8.
To enable this experiment, add '--enable-daala-dist' with configure.
TODO: Significant tuning of parameters is required since the function has
originally came from Daala thus most parameters would not work
correctly outside Daala.
The fact that chroma distortion is added to the distortion of AV1's RDO is
also critical since Daala's distortion function is applied to luma only
and chroma continues to use MSE.
Change-Id: If35fdd3aec7efe401f351ba1c99891ad57a3d957
This commit resolves an enc/dec mismatch issue when both filter-intra
and cb4x4 modes are enabled.
BUG=aomedia:253
Change-Id: I4026d93c00a819f2ce69aedba9d34a774319acbf
This commit enables the adaptive scan order system support
rectangular trnasform block sizes. It resolves the coding failure
when rect-tx or var-tx are enabled.
BUG=aomedia:143
Change-Id: Ic565284e811e3f7e0ebf2e08fb3748257ce8a049
Fix an encoding failure issue when var-tx is enabled, while ext-tx
and rect-tx are disabled. This doesn't change coding statistics
when all are enabled.
Change-Id: I4b32387a0a1497380980f8087832aaf6467cdcbe
This commit makes ext-tx and rect-tx experiments supported in the
cb4x4 mode. It resolves an enc/dec mismatch issue when all the
transform experiments are enabled.
The coding gains are
ext-tx + rect-tx cb4x4 vartx total
lowres 4.0% 2.3% 0.5% 6.9%
The encoding speed is about the same when cb4x4 and vartx are
further enabled.
BUG=aomedia:139
Change-Id: I3fdabc6d5de23ceb78ac0751a9bf7332ebc0a3ac
Properly determine and use horizontal and vertical masks
for loop filtering when rectangular transforms are used.
Fixes an intermittent mismatch issue and improves coding
efficiency.
BDRATE results for ext-tx + rect-tx:
lowres: -3.739% (up from -3.443%)
midres: -3.366% (up from -3.006%)
Change-Id: If26fa14261f3893662eb1245f0b876d68513247c
By turning on CONVOLVE_POST_ROUNDING, in the compound inter
prediction mode, FILTER_BITS rounding is moved after the summation
of two predictions.
Note that the post rounding is only applied on non-sub8x8 block
PSNR BDRate
lowres -0.808% -0.673%
Change-Id: Ib91304e6122c24d832a582ab9f5757d33eac876c
This commit fixes an enc/dec mismatch issue in ext-partition-type
in the cb4x4 mode.
BUG=aomedia:137
Change-Id: I19f538a967a6059a40b1668eed076bc315b46149
This commit resolves the coding pipeline breakage when ext-partition
and cb4x4 are both enabled.
BUG=aomedia:138
Change-Id: Ic17da68af80d7a66565b0e1c69b895be27282a9a
If _d == 0 we are already off to the UB races due to out of bounds
access in OD_DIVU_SMALL_CONSTS.
Change-Id: I55a76c51483885bbb38667f14836be9830e130a8
The warp filter for the (0,1) case is changed to use a real
8-tap filter.
Improves coding efficiency.
BDRATE on lowres:
-0.772% (up from -0.633%) with --enable-global-motion
-1.124% (up from -1.001%) with --enable-warped-motion
Change-Id: I296efe36dbc72a7af74773b71b445f19a2aa7205
+ M_SQRT2 / M_SQRT1_2 to keep the daala diffs down
adapted from:
ebb9b28 Move math.h fills to odintrin.h.
these aren't visible by default with -std=c99.
BUG=aomedia:111
Change-Id: Iaa65986f35d914bf92c8c49a8211e0e6864c64e4
Improve the speed of the warp filter itself by ~30%. This leads
to an overall decoder speedup of 5-20%, depending on bitrate,
for the global-motion experiment, and a small speedup for
warped-motion.
Applies a very minor change to the rounding during filter
selection (ROUND_POWER_OF_TWO makes slightly more sense here
than ROUND_POWER_OF_TWO_SIGNED, and is faster)
Change-Id: I3f364221d1ec35a8aac0d2c8b0e427f527d12e43
* Use the same function for domaintxfmrf in both highbd and lowbd
cases
* Move an assertion out of a loop in
apply_selfguided_restoration_highbd, to match the lowbd case
No change to output, but a decoder speed improvement of ~3.5%
(roughly independent of bitrate) with loop-restoration on a
10bpp sample.
Change-Id: I970a3bb8f1c6b0ac60aa4a6fe4e7f54d1e6c1452
Urvang Joshi
Yue Chen
Jingning Han
Debargha Mukherjee
Thomas Davies
ltrudeau
hui su
Tristan Matthews
David Barker
Yaowu Xu
Angie Chiang
Fangwen Fu
Emil Keyder
Yushin Cho
Alex Converse
Sarah Parker
James Zern