This fixes the following mismatch bugs:
* At the bitstream level, the decoder would not read the delta_qindex
information for supertx blocks, but the encoder always sent it,
leading to the encoder and decoder becoming misaligned.
The delta_qindex information is still required for supertx blocks,
so change the decoder to read it.
* In addition, the quantizer was not properly adjusted for supertx
blocks at the decoder. We copy the quantizer setup code from
non-supertx blocks.
Since this does not change the encoder, it should not have any
quality impact.
Change-Id: I9a0f79c3aa66f2a5a353821e2a6f3b526636e7b4
rd_pick_palette_intra_sby() was being passed a dummy 'best_mbmi' in
one case, and later that dummy value could be assigned to 'mbmi'
causing invalid values in 'mbmi'.
This bug was introduced by:
de0c70a2: Refactor rd_pick_intra_sby_mode()
See the referenced bug for a repro case.
BUG=aomedia:337
Change-Id: If6b0aa329f4e4902cd4de8a5e09bc5d9196492a1
Allow the above combination of experiments to work together
correctly, fixing an encode/decode mismatch bug when they
were all enabled.
This change causes build_masked_compound(_highbd) to only
ever be called if CONFIG_SUPERTX is off, so wrap these functions
in an '#if !CONFIG_SUPERTX' block.
BUG=aomedia:313
Change-Id: Ic3886bc69ba9624b8fcb0a4c2d71fc64d2c0f22c
The issue was that:
- We call av1_setup_pre_planes() when this is not an intra-only frame,
but,
- But, we do motion vector search for any frame other than first frame
Doing both of these only when this is not an intra-only frames makes
logical sense and fixes the crash too.
This also avoids doing motion search for intra-only frames in the first
pass.
Verified that there is no change in compression performance for video,
as well as when forcing all keyframes.
BUG=aomedia:133
Change-Id: I7b18c0568eaa29c6c97f31f226243e5a9dbaecf1
Preparation for merging EOB into multi-symbol encoding.
The more_data flag for the first position is moved
out of the loop, and for remaining positions is
moved in with the previous coefficient. This way it
can always be associated with the previous non-zero
coefficient.
Change-Id: Idfb38058f4c415127b4d9a9beeb8ea2d3a2ec1a2
Zero, one, and two or more coded as one symbol (head).
Remaining tokens coded as a tail symbol.
The pareto CDF distribution is adjusted to cover tokens from
two onwards.
Change-Id: I98b33fab6b9f52690f6ad618ac55e725a97be056
- Added comments for some tables and #defines for clarity.
- Renamed some variables to ensure we use "color_index" instead of
"color" for palette color index related variables.
Change-Id: Ica95a26e0f171a41a3259c8e6b3b891b8cd10151
This commit makes the daala-ec work in the cb4x4 mode. As compared
to --enable-experimental, --enable-experimental --enable-cb4x4
improves the coding performance by:
lowres 2.6%
midres 1.2%
Change-Id: Ifee6f011c80364492c4a547513d24eb2958b5a56
Now that we have small number of contexts (5), use hash multipliers
(instead of base 11), so that color context hash is within a small
range. This allows us to use a lookup table to get color context
instead of a for loop.
Output bitstreams are bit-exact, so no change in compression.
Change-Id: I8cd8c893048c2fc6b22ccbd56f652d11486e2ee9
This reduces the complexity in a number of ways:
- We need just 3 neighbors instead of 4.
- Possible contexts reduce from 16 to 5.
- On hardware side, getting the contexts for a whole block will be more
parallelizable.
At the same time, compression performance improves very slightly:
- Screen-content set (videos) (Google): BDRate improved by 0.32
- screenshots set (images) (AWCY): PSNR improved by 0.62:
https://arewecompressedyet.com/?job=palette_withTR2%402017-01-27T21%3A30%3A28.890Z&job=palette_noTR2%402017-01-27T21%3A41%3A34.312Z
Change-Id: Ie84ca32f05d55ad481a51c2d3abc579468597189
Cherry-pick Daala e248823a
Getting rid of the DCT in od_compute_dist_8x8()
Replacing the DCT and frequency weighting by a filter
Change-Id: Icc3a46e5dbb561e4e3b00fa6c2290d54299c05cb
This commit fixes the encoding/decoding mismatch issue when
ext-partition and ext-partition-type are both turned on in cb4x4
mode.
BUG=aomedia:336
Change-Id: I4d6ad5863c9d3bc8e3a41c259b8b39f130164790
Adjusts the value by 1 to make sure that the center tap
if the Wiener filter does not drop below 0.
BUG=aomedia:315
Change-Id: I41c3a2eb3f36dd49072a4873a995003d18f94ece
Introduced in I745ca032f313c5041aacc98c03ae4bfc33d840de.
Stride should be plane_block_width and width should be cols,
sanity check: cols <= plane_block_width.
Change-Id: Ic5128e94a909e498010c92fef2013da8df6d6d85
Change the list of search offsets searched when ext-partition-types
is on for square block_sizes. This is because the VERTICAL_A and
HORIZONTAL_A partitions are incompatible with the default list.
BUG=AOMEDIA:141
Change-Id: I884c45c3d11039b7dcb72336a928362f926473ed
If part of a block falls outside right and/or bottom image boundary,
then only store tokens for the part of it within the boundary.
Also, consider only the part of the block within the boundary when
calculating the number of colors in the image, deciding the base
colors for palette, RD calculation etc.
The part of color map corresponding to pixels outside the image
boundary is padded with color indices copied from same row/column.
This behavior is similar to how pixels outside the boundary are padded.
For screen_content set, this is improves compression performance by
0.038 overall. One clip, in particular, has a significant gain of 0.8.
Change-Id: I745ca032f313c5041aacc98c03ae4bfc33d840de
Creates the PVQ_SKIP_TYPE enum to encapsulate the different types of
skipping that can be signaled by PVQ (i.e. skip: AC, DC or both).
There is no impact on the bitstream. However, the decoder will now emit
an internal error if the decoded skip flag is out of range. The
block_skip variable is also renamed to ac_dc_coded as it stores the same
information.
Change-Id: Ib2aadaf99dc1736ea392ae5ed8948c3cdc12da9b
Fixes a mismatch issue with ext-inter+motion-var+warped-motion
due to unset num_proj_ref values.
BUG=aomedia:311
Change-Id: I042551f6c53e8cc005f2133704a03b243c98c12a
only expose the static functions needed in the test file to avoid link
errors for e.g., av1_fht4x4_c
Change-Id: I35111d322f30bc2bfc57b32c11f691f0717cfaba
Now that https://aomedia-review.googlesource.com/#/c/6729/
has been merged, build_intra_predictors_for_interintra() is
now redundant, so replace it by a direct call to
av1_predict_intra_block() and remove the old function.
Reset rect_interintra back to 1.
To do this, we need to make the intra predictor take a
BLOCK_SIZE instead of a TX_SIZE. This is because we need to
be able to predict 32x64 and 64x32 blocks, but there is no
TX_32X64 or TX_64X32.
No effect on output or performance.
Change-Id: I8c185a211c97a85012cc54ec293c785a693608ed
Resolve the broken coding pipeline in ext-inter experiment when
cb4x4 mode is enabled. Turn off rectangular inter-intra mode.
This needs some more work to hook up. Given that it gives fairly
limited coding performance gains, disable it for the moment.
BUG=aomedia:309
Change-Id: I9b406df6183f75697bfd4eed5125a6e9436d84b0
This follows the naming for the other frame types, and allows libaom
to be compiled against other libraries that also #define NONE.
Change-Id: Ic2e2814587bbc5ea67385a9af775396d29b7dde0
* The restriction on the parameter 'delta' was too strict, so we
loosen it (delta only ever gets multiplied by -4, ... , 4,
whereas beta gets multiplied by -7, ..., 7)
* Correct a comment about the border clamping
* Fix an issue with the test case
Change-Id: I30e55203455ba6e419b5a8b646151a6d1fd5cc3b
This commit adds a new experiment, Daala's distortion function,
which is designed to better approximate perceptual distortion
in 8x8 pixel blocks.
This experiment is expected to work best with PVQ.
It measures the variance of overlapped 4x4 regions in the 8x8 area,
then uses these variances to scale the MSE of weighted frequency domain
distortion of 8x8 block.
Since AV1 calculates distortion in blocks as small as 4x4, it is not possible to
directly replace the existing distortion functions of AV1,
such as dist_block() and block_rd_txf().
Hence, there has been substantial changes in order to apply
Daala's 8x8 distortion function.
The daala distortion function is applied
after all 4x4 tx blocks in a 8x8 block are encoded (during RDO),
as in below two cases:
1) intra/inter sub8x8 predictions and
2) 4x4 transform with prediction size >= 8.
To enable this experiment, add '--enable-daala-dist' with configure.
TODO: Significant tuning of parameters is required since the function has
originally came from Daala thus most parameters would not work
correctly outside Daala.
The fact that chroma distortion is added to the distortion of AV1's RDO is
also critical since Daala's distortion function is applied to luma only
and chroma continues to use MSE.
Change-Id: If35fdd3aec7efe401f351ba1c99891ad57a3d957
This commit resolves an enc/dec mismatch issue when both filter-intra
and cb4x4 modes are enabled.
BUG=aomedia:253
Change-Id: I4026d93c00a819f2ce69aedba9d34a774319acbf
Joe Young
Debargha Mukherjee
Sebastien Alaiwan
David Barker
Alex Converse
Urvang Joshi
Yue Chen
Sarah Parker
Thomas Davies
Jingning Han
Jean-Marc Valin
Jonathan Matthews
hui su
Yaowu Xu
ltrudeau
Tristan Matthews
James Zern
Angie Chiang
Fangwen Fu
Emil Keyder
Yushin Cho