f r's

CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [Full Changelog](https://github.com/mozilla/application-services/compare/v0.22.1...master)
 
+## Push
+
+### Breaking changes
+
+- the `PushManager` argument `socket_protocol` is now `http_protocol`
+  to correctly map its role. `socket_protocol` is reserved.
+
 # v0.22.1 (_2019-03-27_)
 
 [Full Changelog](https://github.com/mozilla/application-services/compare/v0.22.0...v0.22.1)

components/push/ffi/src/lib.rs

@@ -142,7 +142,7 @@ pub extern "C" fn push_verify_connection(handle: u64, error: &mut ExternError) -
     MANAGER.call_with_result_mut(error, handle, |mgr| -> Result<_> {
         if !mgr.verify_connection()? {
             let new_endpoints = mgr.regenerate_endpoints()?;
-            if new_endpoints.is_empty() {
+            if !new_endpoints.is_empty() {
                 return serde_json::to_string(&new_endpoints).map_err(|e| {
                     push_errors::ErrorKind::TranscodingError(format!("{:?}", e)).into()
                 });