Removed auto-generated metrics.md files, fixed error in publishToLocalMaven with directories (#4098)

automation/publish_to_maven_local_if_modified.py

@@ -82,7 +82,7 @@ for nm in untracked_files:
     try:
         with open(nm, "rb") as f:
             contents_hash.update(f.read())
-    except FileNotFoundError:
+    except (FileNotFoundError, IsADirectoryError):
         pass
     contents_hash.update(b"\x00")
 contents_hash.update(b"\x00")

components/logins/android/build.gradle

@@ -101,8 +101,6 @@ protobuf {
 
 // Needs to happen before `dependencies` in order for the variables
 // exposed by the plugin to be available for this project.
-ext.gleanGenerateMarkdownDocs = true
-ext.gleanDocsDirectory = "$rootDir/docs/metrics/logins"
 apply plugin: "org.mozilla.telemetry.glean-gradle-plugin"
 
 dependencies {

components/nimbus/android/build.gradle

@@ -69,8 +69,6 @@ configurations {
 }
 
 ext.gleanYamlFiles = ["${project.projectDir}/../metrics.yaml"]
-ext.gleanGenerateMarkdownDocs = true
-ext.gleanDocsDirectory = "$rootDir/docs/metrics/nimbus"
 apply plugin: "org.mozilla.telemetry.glean-gradle-plugin"
 
 dependencies {

components/places/android/build.gradle

@@ -96,9 +96,6 @@ protobuf {
     }
 }
 
-// Generate markdown docs for the collected metrics.
-ext.gleanGenerateMarkdownDocs = true
-ext.gleanDocsDirectory = "$rootDir/docs/metrics/places"
 apply plugin: "org.mozilla.telemetry.glean-gradle-plugin"
 
 dependencies {

docs/metrics/logins/metrics.md

@@ -1,34 +0,0 @@
-<!-- AUTOGENERATED BY glean_parser.  DO NOT EDIT. -->
-
-# Metrics
-This document enumerates the metrics collected by this project using the [Glean SDK](https://mozilla.github.io/glean/book/index.html).
-This project may depend on other projects which also collect metrics.
-This means you might have to go searching through the dependency tree to get a full picture of everything collected by this project.
-
-# Pings
-
- - [metrics](#metrics)
-
-
-## metrics
-
-This is a built-in ping that is assembled out of the box by the Glean SDK.
-
-See the Glean SDK documentation for the [`metrics` ping](https://mozilla.github.io/glean/book/user/pings/metrics.html).
-
-The following metrics are added to the ping:
-
-| Name | Type | Description | Data reviews | Extras | Expiration | [Data Sensitivity](https://wiki.mozilla.org/Firefox/Data_Collection) |
-| --- | --- | --- | --- | --- | --- | --- |
-| logins_store.read_query_count |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The total number of read operations performed on the logins store. The count only includes operations triggered by the application, not e.g. incidental reads performed as part of a sync. It is intended to be used together with `read_query_error_count` to measure the overall error rate of read operations on the logins store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1597895), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)||never |2 |
-| logins_store.read_query_error_count |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |The total number of errors encountered during read operations on the logins store, labeled by type. It is intended to be used together with `read_query_count` to measure the overall error rate of read operations on the logins store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1597895), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)|<ul><li>interrupted</li><li>storage_error</li></ul>|never |2 |
-| logins_store.unlock_count |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The number of times the login store was unlocked. It is intended to be used together with `unlock_error_count` to measure the overall error rate of unlocking the logins store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1597895), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)||never |2 |
-| logins_store.unlock_error_count |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |The number of errors encountered when unlocking the logins store, labeled by type. It is intended to be used together with `unlock_count` to measure the overall error rate of unlocking the logins store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1597895), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)|<ul><li>invalid_key</li><li>mismatched_lock</li><li>storage_error</li></ul>|never |2 |
-| logins_store.write_query_count |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The total number of write operations performed on the logins store. The count only includes operations triggered by the application, not e.g. incidental writes performed as part of a sync. It is intended to be used together with `write_query_error_count` to measure the overall error rate of write operations on the logins store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1597895), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)||never |2 |
-| logins_store.write_query_error_count |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |The total number of errors encountered during write operations on the logins store, labeled by type. It is intended to be used together with `write_query_count` to measure the overall error rate of write operations on the logins store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1597895), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)|<ul><li>no_such_record</li><li>id_collision</li><li>interrupted</li><li>invalid_record</li><li>storage_error</li></ul>|never |2 |
-
-
-Data categories are [defined here](https://wiki.mozilla.org/Firefox/Data_Collection).
-
-<!-- AUTOGENERATED BY glean_parser.  DO NOT EDIT. -->
-

docs/metrics/places/metrics.md

@@ -1,32 +0,0 @@
-<!-- AUTOGENERATED BY glean_parser.  DO NOT EDIT. -->
-
-# Metrics
-This document enumerates the metrics collected by this project using the [Glean SDK](https://mozilla.github.io/glean/book/index.html).
-This project may depend on other projects which also collect metrics.
-This means you might have to go searching through the dependency tree to get a full picture of everything collected by this project.
-
-# Pings
-
- - [metrics](#metrics)
-
-
-## metrics
-
-This is a built-in ping that is assembled out of the box by the Glean SDK.
-
-See the Glean SDK documentation for the [`metrics` ping](https://mozilla.github.io/glean/book/user/pings/metrics.html).
-
-The following metrics are added to the ping:
-
-| Name | Type | Description | Data reviews | Extras | Expiration | [Data Sensitivity](https://wiki.mozilla.org/Firefox/Data_Collection) |
-| --- | --- | --- | --- | --- | --- | --- |
-| places_manager.read_query_count |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The total number of read operations performed on the places store. The count only includes operations triggered by the application, not e.g. incidental reads performed as part of a sync. It is intended to be used together with `read_query_error_count` to measure the overall error rate of read operations on the places store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1607621), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)||never |2 |
-| places_manager.read_query_error_count |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |The total number of errors encountered during read operations on the places store, labeled by type. It is intended to be used together with `read_query_count` to measure the overall error rate of read operations on the places store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1607621), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)|<ul><li>url_parse_failed</li><li>operation_interrupted</li></ul>|never |2 |
-| places_manager.write_query_count |[counter](https://mozilla.github.io/glean/book/user/metrics/counter.html) |The total number of write operations performed on the places store. The count only includes operations triggered by the application, not e.g. incidental writes performed as part of a sync. It is intended to be used together with `write_query_error_count` to measure the overall error rate of write operations on the places store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1607621), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)||never |2 |
-| places_manager.write_query_error_count |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |The total number of errors encountered during write operations on the places store, labeled by type. It is intended to be used together with `write_query_count` to measure the overall error rate of write operations on the places store.  |[1](https://bugzilla.mozilla.org/show_bug.cgi?id=1607621), [2](https://bugzilla.mozilla.org/show_bug.cgi?id=1649044), [3](https://bugzilla.mozilla.org/show_bug.cgi?id=1694316)|<ul><li>url_parse_failed</li><li>invalid_bookmark_update</li><li>invalid_parent</li><li>unknown_bookmark_item</li><li>url_too_long</li><li>cannot_update_root</li></ul>|never |2 |
-
-
-Data categories are [defined here](https://wiki.mozilla.org/Firefox/Data_Collection).
-
-<!-- AUTOGENERATED BY glean_parser.  DO NOT EDIT. -->
-