From 7764bd4a644384edc7152213916cc6d8d0ba5761 Mon Sep 17 00:00:00 2001 From: Jan Brasna <1784648+janbrasna@users.noreply.github.com> Date: Wed, 24 Jul 2024 14:07:47 +0200 Subject: [PATCH] Un-inline SVGs with CSP-violating features (#14857) --- .../templates/firefox/welcome/page10.html | 6 +++--- .../templates/firefox/welcome/page11.html | 8 ++++---- .../templates/firefox/welcome/page9.de.html | 10 +++++----- .../templates/firefox/welcome/page9.fr.html | 10 +++++----- .../firefox/whatsnew/includes/fx119/addons.svg | 17 ----------------- .../whatsnew/includes/fx120/fakespot.svg | 5 ----- .../firefox/whatsnew/includes/fx120/qr.svg | 14 -------------- .../firefox/whatsnew/includes/fx120/sync.svg | 8 -------- .../firefox/whatsnew/includes/fx120/toolbar.svg | 13 ------------- media/css/firefox/welcome11.scss | 14 -------------- .../img/firefox/welcome}/page10/laptop.svg | 0 .../img/firefox/welcome}/page10/mobile.svg | 0 .../img/firefox/welcome}/page11/cart.svg | 3 ++- .../img/firefox/welcome}/page11/globe.svg | 3 ++- .../img/firefox/welcome}/page11/lock.svg | 3 ++- .../firefox/welcome}/page9/illo-vpn-lock.svg | 0 .../firefox/welcome}/page9/illo-vpn-speed.svg | 0 17 files changed, 23 insertions(+), 91 deletions(-) delete mode 100644 bedrock/firefox/templates/firefox/whatsnew/includes/fx119/addons.svg delete mode 100644 bedrock/firefox/templates/firefox/whatsnew/includes/fx120/fakespot.svg delete mode 100644 bedrock/firefox/templates/firefox/whatsnew/includes/fx120/qr.svg delete mode 100644 bedrock/firefox/templates/firefox/whatsnew/includes/fx120/sync.svg delete mode 100644 bedrock/firefox/templates/firefox/whatsnew/includes/fx120/toolbar.svg rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page10/laptop.svg (100%) rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page10/mobile.svg (100%) rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page11/cart.svg (97%) rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page11/globe.svg (98%) rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page11/lock.svg (96%) rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page9/illo-vpn-lock.svg (100%) rename {bedrock/firefox/templates/firefox/welcome/includes => media/img/firefox/welcome}/page9/illo-vpn-speed.svg (100%) diff --git a/bedrock/firefox/templates/firefox/welcome/page10.html b/bedrock/firefox/templates/firefox/welcome/page10.html index 3df98735da..104ad66c33 100644 --- a/bedrock/firefox/templates/firefox/welcome/page10.html +++ b/bedrock/firefox/templates/firefox/welcome/page10.html @@ -26,7 +26,7 @@ {% block content_intro %}
- + Mozilla VPN

{{ ftl('welcome-page10-main-heading') }}

{{ ftl('welcome-page10-main-description') }}

@@ -45,7 +45,7 @@
- {% include 'firefox/welcome/includes/page10/laptop.svg' %} +

{{ ftl('welcome-page10-very-fast') }}

@@ -55,7 +55,7 @@
- {% include 'firefox/welcome/includes/page10/mobile.svg' %} +

{{ ftl('welcome-page10-without-trace') }}

diff --git a/bedrock/firefox/templates/firefox/welcome/page11.html b/bedrock/firefox/templates/firefox/welcome/page11.html index df4a2676be..2e883cf0f4 100644 --- a/bedrock/firefox/templates/firefox/welcome/page11.html +++ b/bedrock/firefox/templates/firefox/welcome/page11.html @@ -25,7 +25,7 @@ {% block content_intro %}
- + Mozilla VPN

{{ ftl('welcome-page11-main-heading') }}

@@ -38,7 +38,7 @@
- {% include 'firefox/welcome/includes/page11/globe.svg' %} +

{{ ftl('welcome-page11-it-helps-you-shop') }}

@@ -48,7 +48,7 @@
- {% include 'firefox/welcome/includes/page11/cart.svg' %} +

{{ ftl('welcome-page11-it-prevents-surcharging') }}

@@ -58,7 +58,7 @@
- {% include 'firefox/welcome/includes/page11/lock.svg' %} +

{{ ftl('welcome-page11-it-protects-your-credit') }}

diff --git a/bedrock/firefox/templates/firefox/welcome/page9.de.html b/bedrock/firefox/templates/firefox/welcome/page9.de.html index b9ae3ef9af..029abf0e8b 100644 --- a/bedrock/firefox/templates/firefox/welcome/page9.de.html +++ b/bedrock/firefox/templates/firefox/welcome/page9.de.html @@ -20,14 +20,14 @@ {% block shoulder_cta %}{% endblock %} -{%block page_css %} - {{ super()}} +{% block page_css %} + {{ super() }} {{ css_bundle('protocol-callout') }} {% endblock %} {% block content_intro %} - + {% call callout( title='Standort ändern,
Verbindung sichern,
Privatsphäre schützen.'|safe, @@ -53,7 +53,7 @@
- {% include 'firefox/welcome/includes/page9/illo-vpn-speed.svg' %} +

Schnelle Verbindung

@@ -63,7 +63,7 @@
- {% include 'firefox/welcome/includes/page9/illo-vpn-lock.svg' %} +

Sicher ist sicher

diff --git a/bedrock/firefox/templates/firefox/welcome/page9.fr.html b/bedrock/firefox/templates/firefox/welcome/page9.fr.html index 334de4129d..5fbcd0d361 100644 --- a/bedrock/firefox/templates/firefox/welcome/page9.fr.html +++ b/bedrock/firefox/templates/firefox/welcome/page9.fr.html @@ -20,14 +20,14 @@ {% block shoulder_cta %}{% endblock %} -{%block page_css %} - {{ super()}} +{% block page_css %} + {{ super() }} {{ css_bundle('protocol-callout') }} {% endblock %} {% block content_intro %} - + {% call callout( title='Changez votre localisation, sécurisez votre connexion, protégez votre vie privée.'|safe, @@ -53,7 +53,7 @@
- {% include 'firefox/welcome/includes/page9/illo-vpn-speed.svg' %} +

Connexion rapide

@@ -63,7 +63,7 @@
- {% include 'firefox/welcome/includes/page9/illo-vpn-lock.svg' %} +

Sûr de chez sûr

diff --git a/bedrock/firefox/templates/firefox/whatsnew/includes/fx119/addons.svg b/bedrock/firefox/templates/firefox/whatsnew/includes/fx119/addons.svg deleted file mode 100644 index af3173c0a9..0000000000 --- a/bedrock/firefox/templates/firefox/whatsnew/includes/fx119/addons.svg +++ /dev/null @@ -1,17 +0,0 @@ - - - - - - - - - - - - - - - diff --git a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/fakespot.svg b/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/fakespot.svg deleted file mode 100644 index c11ab24163..0000000000 --- a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/fakespot.svg +++ /dev/null @@ -1,5 +0,0 @@ - - - diff --git a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/qr.svg b/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/qr.svg deleted file mode 100644 index dac357cd75..0000000000 --- a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/qr.svg +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - - - diff --git a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/sync.svg b/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/sync.svg deleted file mode 100644 index 0acb1bb9a0..0000000000 --- a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/sync.svg +++ /dev/null @@ -1,8 +0,0 @@ - - - - diff --git a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/toolbar.svg b/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/toolbar.svg deleted file mode 100644 index d591c6a63b..0000000000 --- a/bedrock/firefox/templates/firefox/whatsnew/includes/fx120/toolbar.svg +++ /dev/null @@ -1,13 +0,0 @@ - - - - - - - - - - - x - - diff --git a/media/css/firefox/welcome11.scss b/media/css/firefox/welcome11.scss index 7628c8cddc..ff46faa213 100644 --- a/media/css/firefox/welcome11.scss +++ b/media/css/firefox/welcome11.scss @@ -117,20 +117,6 @@ $image-path: '/media/protocol/img'; color: $color-violet-20; } - .mzp-c-picto-image { - .invert-stroke { - stroke: #fff; - } - - .invert-fill { - fill: #fff; - } - - .invert-card { - fill: #a77ffa; - } - } - .c-utilities { @include white-links; } diff --git a/bedrock/firefox/templates/firefox/welcome/includes/page10/laptop.svg b/media/img/firefox/welcome/page10/laptop.svg similarity index 100% rename from bedrock/firefox/templates/firefox/welcome/includes/page10/laptop.svg rename to media/img/firefox/welcome/page10/laptop.svg diff --git a/bedrock/firefox/templates/firefox/welcome/includes/page10/mobile.svg b/media/img/firefox/welcome/page10/mobile.svg similarity index 100% rename from bedrock/firefox/templates/firefox/welcome/includes/page10/mobile.svg rename to media/img/firefox/welcome/page10/mobile.svg diff --git a/bedrock/firefox/templates/firefox/welcome/includes/page11/cart.svg b/media/img/firefox/welcome/page11/cart.svg similarity index 97% rename from bedrock/firefox/templates/firefox/welcome/includes/page11/cart.svg rename to media/img/firefox/welcome/page11/cart.svg index 96440eb011..5e861e9feb 100644 --- a/bedrock/firefox/templates/firefox/welcome/includes/page11/cart.svg +++ b/media/img/firefox/welcome/page11/cart.svg @@ -1,4 +1,5 @@ - + + diff --git a/bedrock/firefox/templates/firefox/welcome/includes/page11/globe.svg b/media/img/firefox/welcome/page11/globe.svg similarity index 98% rename from bedrock/firefox/templates/firefox/welcome/includes/page11/globe.svg rename to media/img/firefox/welcome/page11/globe.svg index 9539cdc66d..a08faf44b9 100644 --- a/bedrock/firefox/templates/firefox/welcome/includes/page11/globe.svg +++ b/media/img/firefox/welcome/page11/globe.svg @@ -1,4 +1,5 @@ - + + + diff --git a/bedrock/firefox/templates/firefox/welcome/includes/page9/illo-vpn-lock.svg b/media/img/firefox/welcome/page9/illo-vpn-lock.svg similarity index 100% rename from bedrock/firefox/templates/firefox/welcome/includes/page9/illo-vpn-lock.svg rename to media/img/firefox/welcome/page9/illo-vpn-lock.svg diff --git a/bedrock/firefox/templates/firefox/welcome/includes/page9/illo-vpn-speed.svg b/media/img/firefox/welcome/page9/illo-vpn-speed.svg similarity index 100% rename from bedrock/firefox/templates/firefox/welcome/includes/page9/illo-vpn-speed.svg rename to media/img/firefox/welcome/page9/illo-vpn-speed.svg