From ab337f8c0518cc0cfcba249e0e7578932d764127 Mon Sep 17 00:00:00 2001
From: Alex Gibson <alexgibson@users.noreply.github.com>
Date: Fri, 16 Dec 2022 11:07:37 +0000
Subject: [PATCH] Fix careers listings filtering (Fixes #12490) (#12492)

---
 media/js/careers/listings/filters.es6.js |  4 ++--
 tests/unit/spec/careers/filters.js       | 16 ++++++++--------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/media/js/careers/listings/filters.es6.js b/media/js/careers/listings/filters.es6.js
index de48c14a4b..6f0cafc2a4 100644
--- a/media/js/careers/listings/filters.es6.js
+++ b/media/js/careers/listings/filters.es6.js
@@ -124,7 +124,7 @@ PositionFilters.prototype = {
         for (let i = 0; i < positions.length; i++) {
             const data = positions.item(i).dataset[field];
 
-            if (data.indexOf(value + ',') === -1) {
+            if (data.indexOf(value) === -1) {
                 positions.item(i).classList.add('hidden');
             }
         }
@@ -139,7 +139,7 @@ PositionFilters.prototype = {
         const positions = this.positionTable.getElementsByClassName('position');
 
         for (let i = 0; i < positions.length; i++) {
-            const data = positions.item(i).dataset.location;
+            const data = positions.item(i).dataset.location + ',';
 
             // When user selects 'Remote' only list jobs explicitly marked
             // Remote otherwise list jobs matching value (which is a mozilla
diff --git a/tests/unit/spec/careers/filters.js b/tests/unit/spec/careers/filters.js
index ed6180fe81..8044bcd9a5 100644
--- a/tests/unit/spec/careers/filters.js
+++ b/tests/unit/spec/careers/filters.js
@@ -57,42 +57,42 @@ describe('filters.js', function () {
             </tr>
             </thead>
             <tbody>
-            <tr class="position" data-team="Business Development," data-type="," data-location="San Francisco Office,">
+            <tr class="position" data-team="Business Development" data-type="" data-location="San Francisco Office">
                 <td class="title"><a href="#">Operations Specialist - Business Development</a></td>
                 <td class="location">San Francisco Office</td>
                 <td class="name">Business Development</td>
             </tr>
-            <tr class="position" data-team="Core Product-Firefox," data-type="," data-location="Remote San Francisco Bay Area,">
+            <tr class="position" data-team="Core Product-Firefox" data-type="" data-location="Remote San Francisco Bay Area">
                 <td class="title"><a href="#"> Localization Program Manager </a></td>
                 <td class="location">Remote San Francisco Bay Area</td>
                 <td class="name">Core Product-Firefox</td>
             </tr>
-            <tr class="position" data-team="Core Product-Firefox," data-type="," data-location="Remote Canada,">
+            <tr class="position" data-team="Core Product-Firefox" data-type="" data-location="Remote Canada">
                 <td class="title"><a href="#">Senior Program Manager</a></td>
                 <td class="location">Remote Canada</td>
                 <td class="name">Core Product-Firefox</td>
             </tr>
-            <tr class="position" data-team="Core Product-Security," data-type="," data-location="Remote US,">
+            <tr class="position" data-team="Core Product-Security" data-type="" data-location="Remote US">
                 <td class="title"><a href="#">Senior Software Engineer (C++)</a></td>
                 <td class="location">Remote US</td>
                 <td class="name">Core Product-Security</td>
             </tr>
-            <tr class="position" data-team="Core Product-Security," data-type="," data-location="San Francisco Office,">
+            <tr class="position" data-team="Core Product-Security" data-type="" data-location="San Francisco Office">
                 <td class="title"><a href="#">Senior UI Engineer</a></td>
                 <td class="location">San Francisco Office</td>
                 <td class="name">Core Product-Security</td>
             </tr>
-            <tr class="position" data-team="Data Organization," data-type="," data-location="Remote Canada,Remote Germany,Remote US,">
+            <tr class="position" data-team="Data Organization" data-type="" data-location="Remote Canada,Remote Germany,Remote US">
                 <td class="title"><a href="#">Data Engineer</a></td>
                 <td class="location">Remote Canada, Remote Germany, Remote US</td>
                 <td class="name">Data Organization</td>
             </tr>
-            <tr class="position" data-team="Data Organization," data-type="," data-location="Remote Canada,Remote US,">
+            <tr class="position" data-team="Data Organization" data-type="" data-location="Remote Canada,Remote US">
                 <td class="title"><a href="#">Inference Data Scientist (Staff Level)</a></td>
                 <td class="location">Remote Canada, Remote US</td>
                 <td class="name">Data Organization</td>
             </tr>
-            <tr class="position" data-team="Mozilla Foundation," data-type="," data-location="Remote,">
+            <tr class="position" data-team="Mozilla Foundation" data-type="" data-location="Remote">
                 <td class="title"><a href="#">Senior Software Engineer</a></td>
                 <td class="location">Remote</td>
                 <td class="name">Mozilla Foundation</td>