From ffbb215064bc94495b24c470db3c4f2f264331d3 Mon Sep 17 00:00:00 2001 From: Alex Gibson Date: Fri, 22 Mar 2024 18:09:27 +0000 Subject: [PATCH] Remove pageHasVideo GA event property (Fixes #14331) (#14350) --- media/js/base/core-datalayer-init.js | 1 - media/js/base/core-datalayer.js | 11 ----------- tests/unit/spec/base/core-datalayer.js | 16 ---------------- 3 files changed, 28 deletions(-) diff --git a/media/js/base/core-datalayer-init.js b/media/js/base/core-datalayer-init.js index 75c5e289cf..c2e645c8e3 100644 --- a/media/js/base/core-datalayer-init.js +++ b/media/js/base/core-datalayer-init.js @@ -16,7 +16,6 @@ var dataLayerCore = { event: 'core-datalayer-loaded', pageHasDownload: analytics.pageHasDownload(), - pageHasVideo: analytics.pageHasVideo(), pageVersion: analytics.getPageVersion(), releaseWindowVersion: analytics.getLatestFxVersion() }; diff --git a/media/js/base/core-datalayer.js b/media/js/base/core-datalayer.js index 485e980b96..232116e72d 100644 --- a/media/js/base/core-datalayer.js +++ b/media/js/base/core-datalayer.js @@ -32,17 +32,6 @@ if (typeof window.Mozilla.Analytics === 'undefined') { : 'false'; }; - /** Returns whether page has video. - * @param {String} path - URL path name fallback if page ID does not exist. - * @return {String} string. - */ - analytics.pageHasVideo = function () { - if (!isModernBrowser) { - return 'false'; - } - return document.querySelector('video') !== null ? 'true' : 'false'; - }; - /** Returns page version. * @param {String} path - URL path name fallback if page ID does not exist. * @return {String} version number from URL. diff --git a/tests/unit/spec/base/core-datalayer.js b/tests/unit/spec/base/core-datalayer.js index 1ed31be05e..c19c3c51a3 100644 --- a/tests/unit/spec/base/core-datalayer.js +++ b/tests/unit/spec/base/core-datalayer.js @@ -27,22 +27,6 @@ describe('core-datalayer.js', function () { }); }); - describe('pageHasVideo', function () { - it('will return "true" when HTML5 video is present on page.', function () { - const videoMarkup = ''; - - document.body.insertAdjacentHTML('beforeend', videoMarkup); - expect(Mozilla.Analytics.pageHasVideo()).toBe('true'); - - const content = document.getElementById('video-content'); - content.parentNode.removeChild(content); - }); - - it('will return "false" when download button is not present on page.', function () { - expect(Mozilla.Analytics.pageHasVideo()).toBe('false'); - }); - }); - describe('getPageVersion', function () { it('will return the Firefox version number form the URL if present', function () { expect(