From 0744361f48d9a36f0f9c82f50e31e5f3bdcba711 Mon Sep 17 00:00:00 2001 From: Alekhya <88394696+alekhyamoz@users.noreply.github.com> Date: Tue, 15 Aug 2023 16:06:13 -0400 Subject: [PATCH] Add change control to revenue levers table (#4138) * Add change control to revenue levers table * Fix build error Fix build error * Update sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/metadata.yaml Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com> * Update sql/moz-fx-data-shared-prod/contextual_services_derived/suggest_revenue_levers_daily_v1/metadata.yaml Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com> --------- Co-authored-by: skahmann3 <16420065+skahmann3@users.noreply.github.com> Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com> --- CODEOWNERS | 2 ++ .../suggest_revenue_levers_daily_v1/metadata.yaml | 6 +++++- .../search_revenue_levers_daily_v1/metadata.yaml | 5 +++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index 18989347a8..2503a272eb 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -11,7 +11,9 @@ # Search /sql/moz-fx-data-shared-prod/search_terms @whd @jasonthomas /sql/moz-fx-data-shared-prod/search_terms_derived @whd @jasonthomas +/sql/moz-fx-data-shared-prod/search_dervied/search_revenue_levers_daily_v1 @mozilla/revenue_forecasting_data_reviewers # Contextual Services /sql/moz-fx-data-shared-prod/contextual_services_derived/request_payload_suggest_v2 @mozilla/request_payload_reviewers /sql/moz-fx-data-shared-prod/contextual_services_derived/request_payload_tiles_v2 @mozilla/request_payload_reviewers /sql/moz-fx-data-shared-prod/monitoring_derived/bigquery_usage_v2 @mozilla/dataops +/sql/moz-fx-data-shared-prod/contextual_services_derived/suggest_revenue_levers_daily_v1 @mozilla/revenue_forecasting_data_reviewers diff --git a/sql/moz-fx-data-shared-prod/contextual_services_derived/suggest_revenue_levers_daily_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/contextual_services_derived/suggest_revenue_levers_daily_v1/metadata.yaml index 2ab52f8255..79b91a73fc 100644 --- a/sql/moz-fx-data-shared-prod/contextual_services_derived/suggest_revenue_levers_daily_v1/metadata.yaml +++ b/sql/moz-fx-data-shared-prod/contextual_services_derived/suggest_revenue_levers_daily_v1/metadata.yaml @@ -2,11 +2,15 @@ friendly_name: Suggest Revenue Levers Daily description: |- Daily metrics identified as Suggest revenue levers, including DOU, urlbar search volume, Suggest impressions & Suggest ad impressions, and Suggest ad clicks. + The table is labeled as "change_controlled", which implies + that changes require the approval of at least one owner. owners: -- skahmann@mozilla.com + - skahmann@mozilla.com + - mozilla/revenue_forecasting_data_reviewers labels: incremental: true schedule: daily + change_controlled: true scheduling: dag_name: bqetl_ctxsvc_derived bigquery: diff --git a/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/metadata.yaml index b6495dc1d9..447e036dcd 100644 --- a/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/metadata.yaml +++ b/sql/moz-fx-data-shared-prod/search_derived/search_revenue_levers_daily_v1/metadata.yaml @@ -2,11 +2,16 @@ friendly_name: Search Revenue Levers Daily description: |- Daily metrics identified as search revenue levers, including eligible DOU, DOU_engaged_w_sap, sap, tagged_sap, tagged_follow_on, search_with_ads, and ad_clicks. + The table is labeled as "change_controlled", which implies + that changes require the approval of at least one owner. owners: - xluo@mozilla.com - cmorales@mozilla.com + - mozilla/revenue_forecasting_data_reviewers labels: incremental: true + schedule: daily + change_controlled: true scheduling: dag_name: bqetl_search_dashboard bigquery: