diff --git a/bigquery_etl/query_scheduling/task.py b/bigquery_etl/query_scheduling/task.py index e75e81d302..8620a4d9ba 100644 --- a/bigquery_etl/query_scheduling/task.py +++ b/bigquery_etl/query_scheduling/task.py @@ -263,9 +263,7 @@ class Task: # the order of table dependencies changes between requests # sort to maintain same order between DAG generation runs - sorted_table_names = list(table_names) - sorted_table_names.sort() - return sorted_table_names + return sorted(table_names) def with_dependencies(self, client, dag_collection): """Perfom a dry_run to get upstream dependencies.""" diff --git a/dags.yaml b/dags.yaml index 44bb579898..edc975f53e 100644 --- a/dags.yaml +++ b/dags.yaml @@ -143,7 +143,7 @@ bqetl_main_summary: retries: 2 retry_delay: 30m -bqetl_experiments: +bqetl_experiments_daily: schedule_interval: 0 1 * * * default_args: owner: ssuh@mozilla.com diff --git a/dags/bqetl_experiments.py b/dags/bqetl_experiments_daily.py similarity index 94% rename from dags/bqetl_experiments.py rename to dags/bqetl_experiments_daily.py index cccbb0f185..cb0eee2dba 100644 --- a/dags/bqetl_experiments.py +++ b/dags/bqetl_experiments_daily.py @@ -17,7 +17,7 @@ default_args = { } with DAG( - "bqetl_experiments", default_args=default_args, schedule_interval="0 1 * * *" + "bqetl_experiments_daily", default_args=default_args, schedule_interval="0 1 * * *" ) as dag: telemetry_derived__experiments_daily_active_clients__v1 = bigquery_etl_query( diff --git a/sql/telemetry_derived/experiments_daily_active_clients_v1/metadata.yaml b/sql/telemetry_derived/experiments_daily_active_clients_v1/metadata.yaml index 43c33cf201..4cfbf64f81 100644 --- a/sql/telemetry_derived/experiments_daily_active_clients_v1/metadata.yaml +++ b/sql/telemetry_derived/experiments_daily_active_clients_v1/metadata.yaml @@ -7,4 +7,4 @@ labels: application: experiments schedule: daily scheduling: - dag_name: bqetl_experiments + dag_name: bqetl_experiments_daily diff --git a/tests/query_scheduling/test_task.py b/tests/query_scheduling/test_task.py index 397df130ca..5febada53b 100644 --- a/tests/query_scheduling/test_task.py +++ b/tests/query_scheduling/test_task.py @@ -415,7 +415,7 @@ class TestTask: assert f"{temporary_dataset}__table2__v1" in tables @pytest.mark.integration - def test_muultipart_task_get_dependencies( + def test_multipart_task_get_dependencies( self, tmp_path, bigquery_client, project_id, temporary_dataset ): query_file_path = tmp_path / "sql" / temporary_dataset / "query_v1"