Skipping copying checks for baseline tables for apps marked as not receiving the baseline ping (#4670)

Co-authored-by: Frank Bertsch <frank.bertsch@gmail.com>
This commit is contained in:
kik-kik 2023-12-11 16:51:42 +01:00 коммит произвёл GitHub
Родитель 2db2f3e2de
Коммит 6e2e8f6f68
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 25 добавлений и 1 удалений

Просмотреть файл

@ -18,6 +18,24 @@ from bigquery_etl.util.common import get_table_dir, render, write_sql
APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings" APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings"
PATH = Path(os.path.dirname(__file__)) PATH = Path(os.path.dirname(__file__))
# added as the result of baseline checks being added to the template,
# these apps do not receive a baseline ping causing a very basic row_count
# check to fail. For this reason, the checks relying on this ping
# need to be omitted. For more info see: bug-1868848
NO_BASELINE_PING_APPS = (
"mozilla_vpn",
"mozillavpn_cirrus",
"accounts_backend",
"burnham",
"firefox_reality_pc",
"lockwise_android",
"mach",
"monitor_cirrus",
"moso_mastodon_backend",
"mozphab",
"mozregression",
)
def write_dataset_metadata(output_dir, full_table_id, derived_dataset_metadata=False): def write_dataset_metadata(output_dir, full_table_id, derived_dataset_metadata=False):
""" """
@ -283,7 +301,13 @@ class GleanTable:
artifacts.append(Artifact(table, "init.sql", init_sql)) artifacts.append(Artifact(table, "init.sql", init_sql))
if checks_sql: if checks_sql:
artifacts.append(Artifact(table, "checks.sql", checks_sql)) if "baseline" in table and app_name in NO_BASELINE_PING_APPS:
logging.info(
"Skipped copying ETL check for %s as app: %s is marked as not having baseline ping"
% (table, app_name)
)
else:
artifacts.append(Artifact(table, "checks.sql", checks_sql))
for artifact in artifacts: for artifact in artifacts:
destination = ( destination = (