Don't retry check tasks (#4359)

* Don't retry check tasks

* Update test

* Fix one more test

bigquery_etl/query_scheduling/task.py

@@ -488,6 +488,7 @@ class Task:
         task.query_file_path = query_file
         task.is_dq_check = True
         task.is_dq_check_fail = is_check_fail
+        task.retries = 0
         task.depends_on_fivetran = []
         if task.is_dq_check_fail:
             task.task_name = (

dags/bqetl_download_funnel_attribution.py

@@ -53,6 +53,7 @@ with DAG(
         email=["gleonard@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         parameters=["download_date:DATE:{{macros.ds_add(ds, -1)}}"],
+        retries=0,
     )
 
     ga_derived__downloads_with_attribution__v2 = bigquery_etl_query(

dags/bqetl_firefox_ios.py

@@ -54,6 +54,7 @@ with DAG(
         depends_on_past=False,
         task_concurrency=1,
         parameters=["submission_date:DATE:{{ds}}"],
+        retries=0,
     )
 
     checks__warn_firefox_ios_derived__app_store_funnel__v1 = bigquery_dq_check(
@@ -67,6 +68,7 @@ with DAG(
         depends_on_past=False,
         task_concurrency=1,
         parameters=["submission_date:DATE:{{ds}}"],
+        retries=0,
     )
 
     firefox_ios_derived__app_store_funnel__v1 = bigquery_etl_query(

dags/bqetl_fivetran_costs.py

@@ -58,6 +58,7 @@ with DAG(
         email=["lschiestl@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         task_concurrency=1,
+        retries=0,
     )
 
     checks__fail_fivetran_costs_derived__incremental_mar__v1 = bigquery_dq_check(
@@ -70,6 +71,7 @@ with DAG(
         email=["lschiestl@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         task_concurrency=1,
+        retries=0,
     )
 
     checks__fail_fivetran_costs_derived__monthly_costs__v1 = bigquery_dq_check(
@@ -82,6 +84,7 @@ with DAG(
         email=["lschiestl@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         task_concurrency=1,
+        retries=0,
     )
 
     fivetran_costs_derived__daily_connector_costs__v1 = bigquery_etl_query(

dags/bqetl_ssl_ratios.py

@@ -53,6 +53,7 @@ with DAG(
         email=["chutten@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         parameters=["submission_date:DATE:{{ds}}"],
+        retries=0,
     )
 
     telemetry_derived__ssl_ratios__v1 = bigquery_etl_query(

tests/data/dags/test_dag_external_check_dependency

@@ -50,6 +50,7 @@ with DAG(
         email=["test@example.org"],
         depends_on_past=False,
         parameters=["submission_date:DATE:{{ds}}"],
+        retries=0,
     )
 
     with TaskGroup(

tests/data/dags/test_dag_with_check_dependencies

@@ -50,6 +50,7 @@ with DAG(
         email=["test@example.org"],
         depends_on_past=False,
         parameters=["submission_date:DATE:{{ds}}"],
+        retries=0,
     )
 
     test__query__v1 = bigquery_etl_query(