Add `locale` and non-search engage flag (#5224)

* Add `locale` and non-search engage flag

* Fix test failure

* Fix test expect

sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql

@@ -41,6 +41,7 @@ visit_metadata AS (
     ANY_VALUE(normalized_os_version) AS normalized_os_version,
     ANY_VALUE(normalized_country_code) AS country_code,
     ANY_VALUE(normalized_channel) AS channel,
+    ANY_VALUE(client_info.locale) AS locale,
     ANY_VALUE(client_info.app_display_version) AS browser_version,
     "Firefox Desktop" AS browser_name,
     ANY_VALUE(metrics.string.search_engine_default_engine_id) AS default_search_engine,
@@ -60,7 +61,8 @@ visit_metadata AS (
     ANY_VALUE(
       IF(event_name = "opened", mozfun.map.get_key(event_details, "source"), NULL)
     ) AS newtab_open_source,
-    LOGICAL_OR(event_name IN ("click", "issued", "save")) AS had_non_impression_engagement
+    LOGICAL_OR(event_name IN ("click", "issued", "save")) AS had_non_impression_engagement,
+    LOGICAL_OR(event_name IN ("click", "save")) AS had_non_search_engagement
   FROM
     events_unnested
   GROUP BY

sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/schema.yaml

@@ -23,6 +23,9 @@ fields:
 - mode: NULLABLE
   name: channel
   type: STRING
+- mode: NULLABLE
+  name: locale
+  type: STRING
 - mode: NULLABLE
   name: browser_version
   type: STRING
@@ -98,6 +101,9 @@ fields:
 - mode: NULLABLE
   name: had_non_impression_engagement
   type: BOOLEAN
+- mode: NULLABLE
+  name: had_non_search_engagement
+  type: BOOLEAN
 - fields:
   - mode: NULLABLE
     name: search_engine

tests/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/test_aggregation/expect.yaml

@@ -10,6 +10,7 @@
   activity_segment: lots_of_activity
   browser_name: Firefox Desktop
   had_non_impression_engagement: true
+  had_non_search_engagement: true
   search_interactions:
     - search_engine: Engine1
       search_access_point: urlbar