feat(): Update description, partitioning and clustering setting for fenix_derived.firefox_android_clients_v1 (#4965)

* Update description, partitioning and clustering setting for fenix_derived.firefox_android_clients_v1

* making sure _previous only includes entries older than the submission_date

* adding back parameter settings

* Update sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/metadata.yaml

Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com>

* feat: remove sample_id from clustering

* feat: use first_seen_date as filter when retrieving previous records. This has no impact as first_seen_date is the same as submission_date

---------

Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com>

sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/metadata.yaml

@@ -1,13 +1,13 @@
 friendly_name: Firefox Android Clients
 description: |-
-  First observations for Firefox Android clients of channel Release,
-  retrieved from the earliest pings: baseline, first_session and metrics.
-  The attributes stored in this table include the first attribution,
-  device, OS and ISP details.
-
   This table should be accessed through the user-facing view
   `fenix.firefox_android_clients`.
 
+  Contains a list of Firefox Android clients along with their first attributes
+  retrieved from baseline, first_session and metrics pings.
+
+  This includes information such as their initial geo, OS, ISP, and attribution info.
+
   For analysis purposes, use first_seen_date to query clients that
   effectively appeared on that date. The submission_date indicates
   when the server received the data.
@@ -22,9 +22,12 @@ description: |-
   https://help.adjust.com/en/article/tracker-urls#campaign-structure-parameters.
 owners:
 - lvargas@mozilla.com
+- kik@mozilla.com
 labels:
   application: firefox_android
-  incremental: true
+  # This query results in the table being rebuilt on each run
+  # by merging the existing and new records to update changes and insert new records.
+  incremental: false
   schedule: daily
   owner1: lvargas
 scheduling:
@@ -39,11 +42,9 @@ bigquery:
     type: day
     field: first_seen_date
     require_partition_filter: false
-    expiration_days: null
   clustering:
     fields:
     - channel
-    - sample_id
     - first_reported_country
-    - device_model
+    - distribution_id
 references: {}

sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/query.sql

@@ -435,6 +435,12 @@ _previous AS (
     *
   FROM
     `moz-fx-data-shared-prod.fenix_derived.firefox_android_clients_v1`
+  WHERE
+    {% if is_init() %}
+      FALSE
+    {% else %}
+      first_seen_date < @submission_date
+    {% endif %}
 )
 SELECT
   client_id,

tests/sql/moz-fx-data-shared-prod/fenix_derived/firefox_android_clients_v1/test_baseline_no_first_session_with_activations/expect.yaml

@@ -5,7 +5,7 @@
   first_seen_date: 2023-01-01
   submission_date: 2023-01-01
   last_reported_date: 2023-01-01
-  device_model: model-1
+  device_model: model-2
   last_reported_device_model: model-2
   last_reported_channel: release
   activated: true
@@ -18,7 +18,6 @@
     reported_metrics_ping: true
     reported_first_session_ping: false
     reported_baseline_ping: true
-  meta_attribution_app: 'Test Meta'
 - client_id: client-2
   sample_id: 50
   first_seen_date: 2022-12-25