Hardcode normalized_os as iOS in event_aggregates (#5725)

This commit is contained in:
Curtis Morales 2024-06-05 10:40:14 -04:00 коммит произвёл GitHub
Родитель 3691aff7c9
Коммит 8f474c79a4
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: B5690EEEBB952194
4 изменённых файлов: 6 добавлений и 6 удалений

Просмотреть файл

@ -134,7 +134,9 @@ combined AS (
'phone' AS form_factor, 'phone' AS form_factor,
normalized_country_code AS country, normalized_country_code AS country,
metrics.string.fx_suggest_advertiser AS advertiser, metrics.string.fx_suggest_advertiser AS advertiser,
SPLIT(metadata.user_agent.os, ' ')[SAFE_OFFSET(0)] AS normalized_os, -- This is now hardcoded, we can use the derived `normalized_os` once
-- https://bugzilla.mozilla.org/show_bug.cgi?id=1773722 is fixed
'iOS' AS normalized_os,
client_info.app_channel AS release_channel, client_info.app_channel AS release_channel,
metrics.quantity.fx_suggest_position AS position, metrics.quantity.fx_suggest_position AS position,
-- Only remote settings is in use on mobile -- Only remote settings is in use on mobile

Просмотреть файл

@ -158,7 +158,9 @@ combined AS (
'remote settings' AS provider, 'remote settings' AS provider,
-- Only standard suggestions are in use on mobile -- Only standard suggestions are in use on mobile
'firefox-suggest' AS match_type, 'firefox-suggest' AS match_type,
SPLIT(metadata.user_agent.os, ' ')[SAFE_OFFSET(0)] AS normalized_os, -- This is now hardcoded, we can use the derived `normalized_os` once
-- https://bugzilla.mozilla.org/show_bug.cgi?id=1773722 is fixed
'iOS' AS normalized_os,
-- This is the opt-in for Merino, not in use on mobile -- This is the opt-in for Merino, not in use on mobile
CAST(NULL AS BOOLEAN) AS suggest_data_sharing_enabled, CAST(NULL AS BOOLEAN) AS suggest_data_sharing_enabled,
blocks.query_type, blocks.query_type,

Просмотреть файл

@ -12,8 +12,6 @@
metadata: metadata:
geo: geo:
subdivision1: DC subdivision1: DC
user_agent:
os: iOS 17
client_info: client_info:
app_channel: release app_channel: release
normalized_country_code: US normalized_country_code: US

Просмотреть файл

@ -13,8 +13,6 @@
metadata: metadata:
geo: geo:
subdivision1: DC subdivision1: DC
user_agent:
os: iOS 17
client_info: client_info:
app_channel: release app_channel: release
normalized_country_code: US normalized_country_code: US