Deng 847 remove metadata validation for sql generarated files (#3739)

* DENG-847 Remove the metadata validation for sql_generated files, because the validation needs to be implemented using a CODEOWNERS file in the main branch as well ans sql files. Currently files exist in the generated-sql branch.

---------

Co-authored-by: Lucia Vargas <lvargas@mozilla.com>
This commit is contained in:
Lucia 2023-04-27 16:59:24 +02:00 коммит произвёл GitHub
Родитель 41d44769ae
Коммит cdedba409f
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
2 изменённых файлов: 3 добавлений и 38 удалений

Просмотреть файл

@ -1133,43 +1133,6 @@ def validate(
validate_metadata.validate(query.parent) validate_metadata.validate(query.parent)
dataset_dirs.add(query.parent.parent) dataset_dirs.add(query.parent.parent)
if not query_files:
# run SQL generators if no matching query has been found.
ctx.invoke(
generate_all,
output_dir=ctx.obj["TMP_DIR"],
ignore=[
"country_code_lookup",
"derived_view_schemas",
"events_daily",
"experiment_monitoring",
"feature_usage",
"glean_usage",
"search",
"stable_views",
],
)
query_files = paths_matching_name_pattern(
name, ctx.obj["TMP_DIR"], project_id, ["query.*"]
)
for query in query_files:
ctx.invoke(format, paths=[str(query)])
if not no_dryrun:
ctx.invoke(
dryrun,
paths=[str(query)],
use_cloud_function=use_cloud_function,
project=project_id,
validate_schemas=validate_schemas,
respect_skip=respect_dryrun_skip,
)
validate_metadata.validate(query.parent)
dataset_dirs.add(query.parent.parent)
if no_dryrun: if no_dryrun:
click.echo("Dry run skipped for query files.") click.echo("Dry run skipped for query files.")

Просмотреть файл

@ -127,7 +127,9 @@ flows AS (
AND user_id IS NOT NULL AND user_id IS NOT NULL
) AS pay_setup_engage_with_uid, ) AS pay_setup_engage_with_uid,
-- new fxa after entering the email -- new fxa after entering the email
LOGICAL_OR(event_type IN ("fxa_pay_setup - 3ds_complete", "fxa_pay_setup - success")) AS pay_setup_complete, LOGICAL_OR(
event_type IN ("fxa_pay_setup - 3ds_complete", "fxa_pay_setup - success")
) AS pay_setup_complete,
LOGICAL_OR( LOGICAL_OR(
event_type IN ("fxa_pay_setup - 3ds_complete", "fxa_pay_setup - success") event_type IN ("fxa_pay_setup - 3ds_complete", "fxa_pay_setup - success")
AND user_id IS NULL AND user_id IS NULL