From eb02488f345b3bf4e2f6a5b9f772f40a759f853f Mon Sep 17 00:00:00 2001
From: Curtis Morales <cmorales@mozilla.com>
Date: Wed, 7 Jun 2023 15:25:31 -0400
Subject: [PATCH] Fix google sheets metadata and change from "google_sheet" to
 "google_sheets" for consistency with google (#3914)

---
 bigquery_etl/cli/query.py                                       | 2 +-
 bigquery_etl/metadata/parse_metadata.py                         | 2 +-
 .../static/data_incidents_v1/metadata.yaml                      | 2 +-
 .../static/monitoring_distinct_docids_notes_v1/metadata.yaml    | 2 +-
 .../static/monitoring_missing_columns_notes_v1/metadata.yaml    | 2 +-
 .../metadata.yaml                                               | 2 +-
 .../static/monitoring_schema_errors_notes_v1/metadata.yaml      | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/bigquery_etl/cli/query.py b/bigquery_etl/cli/query.py
index 980c3b0050..828f0ab790 100644
--- a/bigquery_etl/cli/query.py
+++ b/bigquery_etl/cli/query.py
@@ -1843,7 +1843,7 @@ def _deploy_external_data(
 
             if not table.created:
                 if metadata.external_data.format in (
-                    ExternalDataFormat.GOOGLE_SHEET,
+                    ExternalDataFormat.GOOGLE_SHEETS,
                     ExternalDataFormat.CSV,
                 ):
                     external_config = bigquery.ExternalConfig(
diff --git a/bigquery_etl/metadata/parse_metadata.py b/bigquery_etl/metadata/parse_metadata.py
index e086e97313..c819e9df4a 100644
--- a/bigquery_etl/metadata/parse_metadata.py
+++ b/bigquery_etl/metadata/parse_metadata.py
@@ -117,7 +117,7 @@ class WorkgroupAccessMetadata:
 class ExternalDataFormat(enum.Enum):
     """Represents the external types fo data that are supported to be integrated."""
 
-    GOOGLE_SHEET = "google_sheet"
+    GOOGLE_SHEETS = "google_sheets"
     CSV = "csv"
 
 
diff --git a/sql/moz-fx-data-shared-prod/static/data_incidents_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/static/data_incidents_v1/metadata.yaml
index d74d2f83f5..40c4ce141c 100644
--- a/sql/moz-fx-data-shared-prod/static/data_incidents_v1/metadata.yaml
+++ b/sql/moz-fx-data-shared-prod/static/data_incidents_v1/metadata.yaml
@@ -8,7 +8,7 @@ owners:
 labels:
   incremental: false
 external_data:
-  format: google_sheet
+  format: google_sheets
   source_uris:
     - https://docs.google.com/spreadsheets/d/16Cyx_KBieRdQkSBKolivqpBaK2H-VceN9LEZcL0snHg
   options:
diff --git a/sql/moz-fx-data-shared-prod/static/monitoring_distinct_docids_notes_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/static/monitoring_distinct_docids_notes_v1/metadata.yaml
index 695d6d171f..6e7019c79e 100644
--- a/sql/moz-fx-data-shared-prod/static/monitoring_distinct_docids_notes_v1/metadata.yaml
+++ b/sql/moz-fx-data-shared-prod/static/monitoring_distinct_docids_notes_v1/metadata.yaml
@@ -8,7 +8,7 @@ owners:
 labels:
   incremental: false
 external_data:
-  format: google_sheet
+  format: google_sheets
   source_uris:
     - https://docs.google.com/spreadsheets/d/1wMKyIyzp8yW7YpNz6hpFe0sHueeeLHdHr3p-1br2TbA
   options:
diff --git a/sql/moz-fx-data-shared-prod/static/monitoring_missing_columns_notes_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/static/monitoring_missing_columns_notes_v1/metadata.yaml
index 8266f00def..17a03e754a 100644
--- a/sql/moz-fx-data-shared-prod/static/monitoring_missing_columns_notes_v1/metadata.yaml
+++ b/sql/moz-fx-data-shared-prod/static/monitoring_missing_columns_notes_v1/metadata.yaml
@@ -8,7 +8,7 @@ owners:
 labels:
   incremental: false
 external_data:
-  format: google_sheet
+  format: google_sheets
   source_uris:
     - https://docs.google.com/spreadsheets/d/1wMKyIyzp8yW7YpNz6hpFe0sHueeeLHdHr3p-1br2TbA
   options:
diff --git a/sql/moz-fx-data-shared-prod/static/monitoring_missing_document_namespaces_notes_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/static/monitoring_missing_document_namespaces_notes_v1/metadata.yaml
index 8bebaea33a..dd5e281814 100644
--- a/sql/moz-fx-data-shared-prod/static/monitoring_missing_document_namespaces_notes_v1/metadata.yaml
+++ b/sql/moz-fx-data-shared-prod/static/monitoring_missing_document_namespaces_notes_v1/metadata.yaml
@@ -8,7 +8,7 @@ owners:
 labels:
   incremental: false
 external_data:
-  format: google_sheet
+  format: google_sheets
   source_uris:
     - https://docs.google.com/spreadsheets/d/1wMKyIyzp8yW7YpNz6hpFe0sHueeeLHdHr3p-1br2TbA
   options:
diff --git a/sql/moz-fx-data-shared-prod/static/monitoring_schema_errors_notes_v1/metadata.yaml b/sql/moz-fx-data-shared-prod/static/monitoring_schema_errors_notes_v1/metadata.yaml
index 06df7b968b..15454198f6 100644
--- a/sql/moz-fx-data-shared-prod/static/monitoring_schema_errors_notes_v1/metadata.yaml
+++ b/sql/moz-fx-data-shared-prod/static/monitoring_schema_errors_notes_v1/metadata.yaml
@@ -8,7 +8,7 @@ owners:
 labels:
   incremental: false
 external_data:
-  format: google_sheet
+  format: google_sheets
   source_uris:
     - https://docs.google.com/spreadsheets/d/1wMKyIyzp8yW7YpNz6hpFe0sHueeeLHdHr3p-1br2TbA]
   options: