Граф коммитов

5062 Коммитов

Автор SHA1 Сообщение Дата
Sean Rose 0530c1dc81
Fix `verify-format-sql` CI check not reporting SQL formatting issues (#4827)
* Verify the format of the original SQL, not the generated SQL.

The generated SQL gets reformatted by `bqetl query render`.

* Format all SQL.

* Quote column names containing Jinja expressions to prevent `bqetl format` causing invalid SQL.

* Adjust indentation of some comments to align with the formatted SQL.

* Refactor final `SELECT` in `telemetry_derived.clients_first_seen_v2` to work better with `bqetl format` SQL formatting.

* Fix trailing line comments breaking inline block formatting.

* Fix leading whitespace before Jinja comments not being preserved.

* Add `schema.yaml` for `firefox_ios_derived.baseline_clients_yearly_v1`.

So the `deploy-changes-to-stage` CI can work for the downstream `firefox_ios.baseline_clients_yearly` view.

* Add `schema.yaml` for `firefox_accounts_derived/fxa_users_services_daily_v1`.

So the `dry-run-sql` CI can work for the downstream `firefox_accounts_derived.fxa_users_services_last_seen_v1` ETL.

* Correct `schema.yaml` and `init.sql` for `firefox_accounts_derived.fxa_users_last_seen_v1`.

So the `dry-run-sql` CI can work for the downstream `firefox_accounts_derived.fxa_users_last_seen_v1` ETL.

* Fully qualify table reference in `init.sql` for `firefox_accounts_derived.fxa_users_last_seen_v1`.

So the table dependency will get detected by the `deploy-changes-to-stage` CI to deploy it so the `dry-run-sql` CI can work for the `init.sql` file.

* Improve `JinjaComment` inheritance and docstring.

* Implement `Line.ends_with_line_comment` property and refactor `inline_block_format()`.
2024-01-22 11:48:08 -08:00
Alexander befe468aea
Use rich for backfill CLI (#4866) 2024-01-22 13:47:01 -05:00
kik-kik df2f59f1a9
fixing invalid dependency for irefox_ios_derived/funnel_retention_clients_week_4_v1 (#4861) 2024-01-22 17:41:07 +01:00
Katie Windau d1510d8236
WWW Site Metrics Summary V2 - update query logic (#4864)
* WWW Site Metrics Summary V2 - update query logic

* Update sql/moz-fx-data-marketing-prod/ga_derived/www_site_metrics_summary_v2/query.sql

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>

---------

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
2024-01-19 19:14:58 -06:00
Winnie Chan 535af44005
Revert "point monitoring.bigquery_usage view from monitoring_derived.bigquery…" (#4862) 2024-01-19 13:41:47 -08:00
Alexander f5ee129b63
Restrict derived view schema generation to views with upstream schema files and directly copy reference schemas for simple views. (#4848)
* Refactor
* Copy reference schema directly if it's available
* Refactor default view code
2024-01-19 16:24:50 -05:00
Frank Bertsch 8628388eaf
Add diff_query_schema function util (#4860)
* Add diff_query_schema function for utils

* Use mozdata instead of shared-prod

Co-authored-by: Anna Scholtz <anna@scholtzan.net>

* Delete tables as cleanup

* Apply suggestions from code review

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>

* Compare types, add differs col

* Reformat query

* Update sql/mozfun/utils/diff_query_schemas/README.md

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>

---------

Co-authored-by: Anna Scholtz <anna@scholtzan.net>
Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
2024-01-19 16:09:54 -05:00
Sean Rose a912c28c68
Fix `bqetl stage` to create parent dataset for stored procedures. (#4863) 2024-01-19 12:46:35 -08:00
whd 575adc35e4
Remove defunct PBD views (#4858) 2024-01-19 09:08:02 -08:00
kik-kik 5c6f1429fb
feat(DENG-1590): added existing fxa tables to shredder config (#4851)
* added existing fxa tables to shredder config

* Apply suggestions from code review

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>

* removing some of the fxa tables from the config as suggested by srose

---------

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
2024-01-19 12:56:28 +01:00
kik-kik 28196fc3d4
feat(DENG-1697): Descheduled all FxA queries using the old AWS based tables (#4831)
* Descheduled all fxa queries using the old AWS based tables

* Apply suggestions from code review

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>

* added scheduling back to fxa_stdout_events_v1 and the corresponding nonprod as they are still receiving new data

* Apply suggestions from code review

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>

---------

Co-authored-by: Sean Rose <1994030+sean-rose@users.noreply.github.com>
2024-01-19 12:39:13 +01:00
Marlene Hirose 560581255d
add to metadata.yaml to deprecate bigquery_usage_v1 (#4857) 2024-01-18 14:01:00 -08:00
Katie Windau db15c21586
1866834 - add public json true flag (#4855) 2024-01-18 11:13:29 -06:00
kik-kik 2271200dd9
updated firefox_ios_clients view to reflect is_activated being dropped (#4854) 2024-01-18 16:49:06 +01:00
kik-kik 5f35f082a2
removed activations field from firefox_ios_clients_v1 (#4853) 2024-01-18 16:23:54 +01:00
Anna Scholtz ece50f6d2c
Fix duplicate wait_for tasks in public data JSON DAG (#4849)
Co-authored-by: Katie Windau <153020235+kwindau@users.noreply.github.com>
2024-01-18 08:55:53 -06:00
kik-kik 573d5e2658
added firefox_ios_derived.firefox_ios_clients_v1 to shredder config (#4852) 2024-01-18 15:33:10 +01:00
kik-kik 0bfc394689
added fenix client funnels to shredder config (#4833) 2024-01-18 11:48:48 +01:00
Katie Windau 9bdaa644cd
1866834 - remove flag (#4847) 2024-01-17 15:06:23 -06:00
Katie Windau c6e8f2355f
1866834 - add public json (#4845) 2024-01-17 13:03:50 -06:00
Katie Windau b6f092b4d8
DENG-2262 desktop installs v1 - rename cols & add new columns (#4842)
* Initial commit - work in progress

* DENG-2262 - updating column names

* DENG-2262 - renaming columns and adding 2 new columns

* DENG-2262 - fix typo in data type in schema.yaml
2024-01-17 10:55:00 -06:00
Alexander fe62e09781
Remove remaining mentions of no_partition (#4803) 2024-01-17 10:38:47 -05:00
Sean Rose 9aea89370b
Add `fxa_delete_events_v2` ETL based on FxA logs from GCP (#4843)
* Add `fxa_delete_events_v2` ETL based on FxA logs from GCP.

* Add `fxa_delete_events` view combining `fxa_delete_events_v1` and `fxa_delete_events_v2` data.

* Use `fxa_delete_events` view for Shredder.

* Update sql/moz-fx-data-shared-prod/firefox_accounts_derived/fxa_delete_events_v2/metadata.yaml

---------

Co-authored-by: kik-kik <42538694+kik-kik@users.noreply.github.com>
2024-01-17 14:34:54 +01:00
Sean Rose 369b05aa26
Fix typo in `CODEOWNERS` path for `search_derived.search_revenue_levers_daily_v1`. (#4837) 2024-01-16 15:05:42 -08:00
Katie Windau 489e4bc6a3
1866834 - deprecate V1 use counter tables (#4841) 2024-01-16 16:41:03 -06:00
Anna Scholtz 61e48a473d
Remove duplicate sample_id from events stream tables (#4840) 2024-01-16 14:13:23 -08:00
Anna Scholtz 75cc53e328
Fix events stream metadata and sample_id (#4839) 2024-01-16 11:11:11 -08:00
Anna Scholtz 236d1eb880
Fix events stream tables event category and name concatenation (#4838) 2024-01-16 11:05:46 -08:00
Jan-Erik Rediger 1c7e4b35a4
Add a generator for events stream tables (#4655)
* Add a generator for events stream tables

Open questions:

* How does init work?
  * Is this manually triggered? How do we backfill to a certain date?
* Schema is defined in SQL query. How does this behave on changes in
  the future?
* Configuration: Right now inline in Python. Should we change this?

TODO:

* check table Schema

* Store category and name separately to help with filtering and clustering

* Concat into full event name using array to avoid NULL issues

* events stream: Read allowed apps from project configuration

* event stream: Cluster by event category

* Remove trailing commas

Co-authored-by: Anna Scholtz <anna@scholtzan.net>

* Update sql_generators/glean_usage/events_stream.py

* Update sql_generators/glean_usage/templates/events_stream_v1.metadata.yaml

* Update sql_generators/glean_usage/templates/events_stream_v1.query.sql

* Update sql_generators/glean_usage/templates/events_stream_v1.query.sql

* Update sql_generators/glean_usage/templates/events_stream_v1.query.sql

* Update sql_generators/glean_usage/templates/events_stream_v1.query.sql

* Update sql_generators/glean_usage/templates/events_stream_v1.query.sql

* Update sql_generators/glean_usage/common.py

* Update sql_generators/glean_usage/events_stream.py

---------

Co-authored-by: Anna Scholtz <anna@scholtzan.net>
2024-01-16 10:56:11 -08:00
akkomar c3fa65a30e
Bug 1874697 - Unschedule deletion_request_volume_v1 (#4836)
This query was superseded by v2 added in https://github.com/mozilla/bigquery-etl/pull/4442 and is no longer working after payload_bytes_decoded tables have been removed.
2024-01-16 08:30:43 -08:00
kik-kik 35910b71f4
feat(DENG-2083): updated the source of is_activated inside the firefox_ios_clients view (#4830)
* updated the source of is_activated inside the firefox_ios_clients view

* reading the missing create or replace statement
2024-01-15 17:32:02 +01:00
Anna Scholtz 2c3de50774
Fix null casting in script (#4829) 2024-01-12 13:52:42 -08:00
akkomar 50d1f6a3e4
DENG-1516 Create Treeherder syndication dataset (#4727)
Co-authored-by: whd <whd@users.noreply.github.com>
2024-01-12 21:07:09 +00:00
Anna Scholtz 9393e49e81
Use canonical app name for event flow monitoring (#4828) 2024-01-12 11:56:44 -08:00
Anna Scholtz fc3ae24537
Fix references in structured_detailed_error_counts (#4826) 2024-01-12 09:58:36 -08:00
Anna Scholtz 38c44e0327
Fix event_flow_monitoring metadata template (#4825) 2024-01-12 09:17:49 -08:00
kik-kik 93c411fe79
# bug(): wrapping commented out test in jinja comment to exclude it from the final output (#4812)
* wrapping commented out test in {% raw %} as otherwise it is rendered uncommented

* using jinja comment syntax instead of raw as suggested by lelilia
2024-01-12 17:50:43 +01:00
Sean Rose 62743d64dd
Fix test for `norm.fenix_app_info` UDF. (#4824) 2024-01-12 08:31:18 -08:00
Leli 9c1be71796
DENG-1729 add data-review-stats view to telemetry dev cycle (#4823) 2024-01-12 17:01:31 +01:00
Katie Windau 954d228775
1866834 - update use counters views (#4822) 2024-01-12 09:18:13 -06:00
Jan-Erik Rediger ad15d5f2bf
Pick last expires and types from the history (#4811)
The history is ordered from first introduction of the metric to the
latest change.
So the last element is the _current_ valid value for expires (and types).

For example this can be seen for `top_sites.contile_reporting_url` in
Firefox Android which initially was set to expire in v112, but has been
change to never expire later. The current database still lists 112 for
it though.

Co-authored-by: Leli <33942105+lelilia@users.noreply.github.com>
2024-01-12 14:15:01 +01:00
Leli 0d70573048
issue 4793 - Telemetry Dev Cycle - use in_source to determine if metric is active (#4808) 2024-01-12 13:42:22 +01:00
Marlene Hirose 41be6e2f63
Revert "start deprecation process by editing the metadata.yaml file" (#4818) 2024-01-11 17:51:35 -08:00
Sean Rose 3062b502f9
Escape underscores in `LIKE` patterns (#4810) 2024-01-11 17:21:24 -08:00
Eduardo Filho 4d785d6e84
Fix typo on task name (#4819) 2024-01-11 19:20:44 -05:00
Sean Rose 1d1addb86c
Indent join conditions (#4223)
* Indent join conditions.

* Put parentheses around some `BETWEEN ... AND ...` join conditions.
2024-01-11 15:50:26 -08:00
Lucia 6bf9506ad7
Update checks to match new naming dau=daily_users & qdau=dau. (#4804) 2024-01-11 17:19:13 -05:00
dependabot[bot] 5ce1f9ae6e
Bump ujson from 5.8.0 to 5.9.0 (#4758)
Bumps [ujson](https://github.com/ultrajson/ultrajson) from 5.8.0 to 5.9.0.
- [Release notes](https://github.com/ultrajson/ultrajson/releases)
- [Commits](https://github.com/ultrajson/ultrajson/compare/5.8.0...5.9.0)

---
updated-dependencies:
- dependency-name: ujson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 13:01:45 -08:00
dependabot[bot] c7bd427d85
Bump authlib from 1.2.1 to 1.3.0 (#4760)
Bumps [authlib](https://github.com/lepture/authlib) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/lepture/authlib/releases)
- [Changelog](https://github.com/lepture/authlib/blob/master/docs/changelog.rst)
- [Commits](https://github.com/lepture/authlib/compare/v1.2.1...v1.3.0)

---
updated-dependencies:
- dependency-name: authlib
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 12:40:59 -08:00
dependabot[bot] 47a13f401b
Bump jinja2 from 3.1.2 to 3.1.3 (#4816)
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](https://github.com/pallets/jinja/compare/3.1.2...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-11 12:12:28 -08:00