added more secure credenitals management

.env-dist

@@ -119,6 +119,9 @@ E2E_TEST_BASE_URL=
 E2E_TEST_ACCOUNT_EMAIL=
 E2E_TEST_ACCOUNT_PASSWORD=
 
+E2E_TEST_ACCOUNT_EMAIL_ZERO_BREACHES=
+E2E_TEST_ACCOUNT_EMAIL_EXPOSURES_STARTED=
+
 # Monitor Premium features
 # Link to start user on the subscription process. PREMIUM_ENABLED must be set to `true`.
 FXA_SUBSCRIPTIONS_URL=https://accounts.stage.mozaws.net/subscriptions

.github/workflows/e2e_cron.yml

@@ -55,6 +55,8 @@ jobs:
           E2E_TEST_BASE_URL: ${{ secrets.E2E_TEST_BASE_URL }}
           E2E_TEST_ACCOUNT_EMAIL: ${{ secrets.E2E_TEST_ACCOUNT_EMAIL }}
           E2E_TEST_ACCOUNT_PASSWORD: ${{ secrets.E2E_TEST_ACCOUNT_PASSWORD }}
+          E2E_TEST_ACCOUNT_EMAIL_ZERO_BREACHES: ${{ secrets.E2E_TEST_ACCOUNT_EMAIL_ZERO_BREACHES }}
+          E2E_TEST_ACCOUNT_EMAIL_EXPOSURES_STARTED: ${{ secrets.E2E_TEST_ACCOUNT_EMAIL_EXPOSURES_STARTED }}
           ADMINS: ${{ secrets.ADMINS }}
           FXA_ENABLED: true
           OAUTH_CLIENT_SECRET: ${{ secrets.OAUTH_CLIENT_SECRET }}

.github/workflows/e2e_pr.yml

@@ -70,6 +70,8 @@ jobs:
           E2E_TEST_ENV: ${{ inputs.environment != null && inputs.environment || 'local' }}
           E2E_TEST_BASE_URL: ${{ secrets.E2E_TEST_BASE_URL }}
           E2E_TEST_ACCOUNT_EMAIL: ${{ secrets.E2E_TEST_ACCOUNT_EMAIL }}
+          E2E_TEST_ACCOUNT_EMAIL_ZERO_BREACHES: ${{ secrets.E2E_TEST_ACCOUNT_EMAIL_ZERO_BREACHES }}
+          E2E_TEST_ACCOUNT_EMAIL_EXPOSURES_STARTED: ${{ secrets.E2E_TEST_ACCOUNT_EMAIL_EXPOSURES_STARTED }}
           E2E_TEST_ACCOUNT_PASSWORD: ${{ secrets.E2E_TEST_ACCOUNT_PASSWORD }}
           ADMINS: ${{ secrets.ADMINS }}
           FXA_ENABLED: true

src/e2e/pages/dashBoardPage.ts

@@ -79,6 +79,7 @@ export class DashboardPage {
   readonly privacyNoticeFooter: Locator;
   readonly githubFooter: Locator;
 
+  readonly overviewCard: Locator;
   readonly overviewCardSummary: Locator;
   readonly overviewCardFindings: Locator;
 
@@ -241,6 +242,7 @@ export class DashboardPage {
 
     //upsell button
     this.upsellScreenButton = page.getByText(/Let’s (keep going|fix it)/);
+    this.overviewCard = page.locator("[class*='DashboardTopBanner_container']");
     this.overviewCardSummary = page.locator(
       "[aria-label='Dashboard summary'] > div > p",
     );

src/e2e/specs/dashboard.spec.ts

@@ -721,13 +721,12 @@ test.describe(`${process.env.E2E_TEST_ENV} - Breaches Dashboard - Navigation`, (
 
 test.describe(`${process.env.E2E_TEST_ENV} - Breaches Dashboard - Data Breaches`, () => {
   test.beforeEach(async ({ landingPage, page, authPage }) => {
-    await forceLoginAs(
-      "joe@mailinator.com",
-      "TestPass1234",
-      page,
-      landingPage,
-      authPage,
-    );
+    const emailToUse = process.env
+      .E2E_TEST_ACCOUNT_EMAIL_EXPOSURES_STARTED as string;
+    const pwdToUse = process.env.E2E_TEST_ACCOUNT_PASSWORD as string;
+    expect(emailToUse).not.toBeUndefined();
+    expect(pwdToUse).not.toBeUndefined();
+    await forceLoginAs(emailToUse, pwdToUse, page, landingPage, authPage);
   });
 
   test("Verify that the High risk data breaches step is displayed correctly", async ({

src/e2e/utils/helpers.ts

@@ -220,5 +220,5 @@ export const forceLoginAs = async (
   }
   await authPage.signIn(email, password);
   await page.waitForURL("**/user/dashboard");
-  expect(page.url()).toContain("/user/dashboard");
+  await expect(page).toHaveURL(/.*\/user\/dashboard.*/);
 };