Merge pull request #1075 from mozilla/update-breach-alert-subject

Add and use new string for the subject of breach alert emails.

controllers/email-l10n.js

@@ -27,7 +27,7 @@ function getEmailMockUps(req, res) {
       emailSubject = req.fluentFormat("user-verify-email-report-subject");
       if(emailType === "breachAlert") {
         breachAlert = unsafeBreachesForEmail[0];
-        emailSubject = req.fluentFormat("hibp-notify-email-subject");
+        emailSubject = req.fluentFormat("breach-alert-subject");
       }
     } else if (emailType === "multipleBreaches") {
       const breachArray = ["Experian", "Dropbox", "Apollo"];

controllers/hibp.js

@@ -90,7 +90,7 @@ async function notify (req, res) {
       {defaultLocale: "en"}
     );
 
-    const subject = LocaleUtils.fluentFormat(supportedLocales, "hibp-notify-email-subject");
+    const subject = LocaleUtils.fluentFormat(supportedLocales, "breach-alert-subject");
     const template = "default_email";
     if (!notifiedRecipients.includes(breachedEmail)) {
       await EmailUtils.sendEmail(

locales/en/app.ftl

@@ -31,8 +31,6 @@ error-hibp-connect = Error connecting to {-brand-HIBP}.
 error-hibp-load-breaches = Could not load breaches.
 error-must-be-signed-in = You must be signed in to your {-brand-fxa}.
 
-hibp-notify-email-subject = {-product-name} Alert: Your account was involved in a breach.
-
 home-title = {-product-name}
 home-not-found = Page not found.
 

tests/controllers/hibp.test.js

@@ -59,7 +59,7 @@ async function checkNotifyCallsEverythingItShould(breachedEmail, recipientEmail)
   expect (mockFluentFormatCalls.length).toBe(1);
   const mockFluentFormatCallArgs = mockFluentFormatCalls[0];
   expect (mockFluentFormatCallArgs[0]).toEqual(["en"]);
-  expect (mockFluentFormatCallArgs[1]).toBe("hibp-notify-email-subject");
+  expect (mockFluentFormatCallArgs[1]).toBe("breach-alert-subject");
 
   const mockSendEmailCalls = EmailUtils.sendEmail.mock.calls;
   expect (mockSendEmailCalls.length).toBe(1);