Make Phabricator deployment a required argument of the test selection and risk analysis hooks

infra/taskcluster-hook-classify-patch.json

@@ -86,6 +86,7 @@
             }
         },
         "required": [
+            "PHABRICATOR_DEPLOYMENT",
             "DIFF_ID"
         ],
         "type": "object"

infra/taskcluster-hook-test-select.json

@@ -89,6 +89,7 @@
             }
         },
         "required": [
+            "PHABRICATOR_DEPLOYMENT",
             "DIFF_ID"
         ],
         "type": "object"

scripts/commit_classifier.py

@@ -751,12 +751,11 @@ def main():
     parser.add_argument("model", help="Which model to use for evaluation")
     parser.add_argument("cache_root", help="Cache for repository clones.")
     parser.add_argument("diff_id", help="diff ID to analyze.", type=int)
-    # TODO: The "" choice can be removed when all users have been updated to pass a correct phabricator_deployment.
     parser.add_argument(
         "phabricator_deployment",
         help="Which Phabricator deployment to hit.",
         type=str,
-        choices=["", PHAB_PROD, PHAB_DEV],
+        choices=[PHAB_PROD, PHAB_DEV],
     )
     parser.add_argument(
         "--runnable-jobs",
@@ -773,11 +772,6 @@ def main():
 
     args = parser.parse_args()
 
-    # TODO: This can be removed when all users have been updated to pass a correct phabricator_deployment.
-    args.phabricator_deployment = (
-        args.phabricator_deployment if args.phabricator_deployment else PHAB_PROD
-    )
-
     classifier = CommitClassifier(
         args.model, args.cache_root, args.git_repo_dir, args.method_defect_predictor_dir
     )

tests/test_hooks.py

@@ -19,8 +19,6 @@ with open(os.path.join("VERSION")) as f:
 parameters = [
     (os.path.realpath("infra/taskcluster-hook-data-pipeline.json"), {}),
     (os.path.realpath("infra/taskcluster-hook-check-models-start.json"), {}),
-    (os.path.realpath("infra/taskcluster-hook-classify-patch.json"), {"DIFF_ID": 123}),
-    (os.path.realpath("infra/taskcluster-hook-test-select.json"), {"DIFF_ID": 123}),
     (
         os.path.realpath("infra/taskcluster-hook-classify-patch.json"),
         {"PHABRICATOR_DEPLOYMENT": "prod", "DIFF_ID": 123},