2014-02-25 01:29:49 +04:00
|
|
|
# Copyright 2014 The Chromium Authors. All rights reserved.
|
|
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
|
|
# found in the LICENSE file.
|
|
|
|
|
2016-08-06 03:03:45 +03:00
|
|
|
# =============================================
|
|
|
|
# PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
|
|
|
|
# =============================================
|
2014-02-25 01:29:49 +04:00
|
|
|
#
|
2016-08-06 03:03:45 +03:00
|
|
|
# These flags are effectively global. Your feature flag should go near the
|
|
|
|
# code it controls. Most of these items are here now because they control
|
|
|
|
# legacy global #defines passed to the compiler (now replaced with generated
|
|
|
|
# buildflag headers -- see //build/buildflag_header.gni).
|
2014-02-25 01:29:49 +04:00
|
|
|
#
|
2016-08-06 03:03:45 +03:00
|
|
|
# There is more advice on where to put build flags in the "Build flag" section
|
|
|
|
# of //build/config/BUILDCONFIG.gn.
|
2014-02-25 01:29:49 +04:00
|
|
|
|
2015-05-02 01:36:23 +03:00
|
|
|
import("//build/config/chrome_build.gni")
|
2015-09-21 20:56:26 +03:00
|
|
|
import("//build/config/chromecast_build.gni")
|
2014-07-01 03:24:31 +04:00
|
|
|
|
2014-02-25 01:29:49 +04:00
|
|
|
declare_args() {
|
2016-03-12 07:39:32 +03:00
|
|
|
# Enables proprietary codecs and demuxers; e.g. H264, AAC, MP3, and MP4.
|
|
|
|
# We always build Google Chrome and Chromecast with proprietary codecs.
|
2017-01-21 03:28:06 +03:00
|
|
|
#
|
|
|
|
# Note: this flag is used by WebRTC which is DEPSed into Chrome. Moving it
|
|
|
|
# out of //build will require using the build_overrides directory.
|
Re-Revert "Enable proprietary_codecs=true by default."
This reverts commit 2eb71b67e66737aa1fd7a0b71fe2daedd2bd7bea.
When we reverted the proprietary_codecs=true change the first time,
that caused some layout tests to fail because we had landed
crrev.com/827659 (which depended on the flag being true).
We have now reverted 827659, in crrev.com/c/837247, so it should
be safe to re-revert this here.
Original change's description:
> Revert "Revert "Enable proprietary_codecs=true by default.""
>
> This reverts commit e65278298429af56ed3022b807bd3208ec1ec9ea.
>
> Reason for revert: looks like it's causing consistent layout test failures on Linux Trusty
>
> Original change's description:
> > Revert "Enable proprietary_codecs=true by default."
> >
> > This reverts commit 7f446eb0ecff4014853501cd6d50fcf8ff6fa98b.
> >
> > Reason for revert: reverting for now, now that we've established that it seems to work.
> >
> > Original change's description:
> > > Enable proprietary_codecs=true by default.
> > >
> > > We want most of our test coverage to be done against builds with
> > > the proprietary codecs included, so this changes the default to
> > > do so. However, it is important that we *not* publicize or distribute
> > > any builds that includes these codecs (since they likely won't have
> > > the correct licensing), and so we explicitly turn the flag off on
> > > the builders that do publish builds.
> > >
> > > This change includes a roll of the FFmpeg repo from 423f74fa..c94da9e8
> > > in order to pick up that change, which changes ffmpeg to pick up
> > > `ffmpeg_branding`'s default value directly from `proprietary_codecs`,
> > > making the actual ffmpeg_branding GN arg kinda pointless (the branding
> > > is now driven by proprietary_codecs and is_chromeos).
> > >
> > > R=dalecurtis@chromium.org, chcunningham@chromium.org, jbudorick@chromium.org, kbr@chromium.org
> > >
> > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > > Change-Id: Id0b6cccbd235875c9386a527cb39c8f17d2dab03
> > > Reviewed-on: https://chromium-review.googlesource.com/832383
> > > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
> > > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#525172}
> >
> > TBR=dalecurtis@chromium.org,dpranke@chromium.org,kbr@chromium.org,chcunningham@chromium.org,jbudorick@chromium.org
> > BUG=795935
> >
> > Change-Id: I30b9d447facc94f3eaaa55c7252e3f050720619f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> > Reviewed-on: https://chromium-review.googlesource.com/836414
> > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#525364}
>
> TBR=dalecurtis@chromium.org,dpranke@chromium.org,kbr@chromium.org,chcunningham@chromium.org,jbudorick@chromium.org
>
> Change-Id: I4d8101bdab9fe17ad96d3e1fdaaa62626181769e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 795935
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Reviewed-on: https://chromium-review.googlesource.com/836670
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Commit-Queue: Roger McFarlane <rogerm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525398}
TBR=dalecurtis@chromium.org,rogerm@chromium.org,dpranke@chromium.org,kbr@chromium.org,chcunningham@chromium.org,jbudorick@chromium.org
Change-Id: I36a30feaa5fe52633fecde9ebeea29db7dbc3563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 795935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/837513
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525426}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 696298979b501b7bb06776e0e95f053f8d53a86d
2017-12-20 23:16:56 +03:00
|
|
|
proprietary_codecs = is_chrome_branded || is_chromecast
|
2015-03-02 11:46:09 +03:00
|
|
|
|
2016-04-01 14:33:43 +03:00
|
|
|
# libudev usage. This currently only affects the content layer.
|
|
|
|
use_udev = is_linux && !is_chromecast
|
|
|
|
|
|
|
|
use_dbus = is_linux && !is_chromecast
|
|
|
|
|
|
|
|
use_gio = is_linux && !is_chromeos && !is_chromecast
|
2014-02-25 01:29:49 +04:00
|
|
|
}
|
2016-08-06 03:03:45 +03:00
|
|
|
#
|
|
|
|
# =============================================
|
|
|
|
# PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
|
|
|
|
# =============================================
|
|
|
|
#
|
|
|
|
# See comment at the top.
|