Revert 169670 (Still no dice on cros, I updated crbug.com/159580 with the problem)

- Revert 169592: Now that the libvpx roll is in, this should work.

 - Revert 169589: Caused a bunch of
chromeos-chrome-25.0.1336.0_alpha-r1: /var/cache/chromeos-cache/distfiles/target/chrome-src/src/third_party/libvpx/source/libvpx/vp8/encoder/x86/quantize_sse2.asm:58: error: undefined symbol `vp8_block_coeff' (first use)

Likely because third_party/libvpx/libvpx.gyp still uses the old form.

- Use new -fsanitize=address instead of deprecated -faddress-sanitizer

BUG=159580,162783

Review URL: https://codereview.chromium.org/11416192

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11411191

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11308229

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11428030

git-svn-id: http://src.chromium.org/svn/trunk/src/build@169692 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

common.gypi

@@ -2700,12 +2700,13 @@
             'target_conditions': [
               ['_toolset=="target"', {
                 'cflags': [
-                  '-fsanitize=address',
+                  '-faddress-sanitizer',
                   '-fno-omit-frame-pointer',
-                  '-w',  # http://crbug.com/162783
+                  # See http://crbug.com/159580
+                  '-w',
                 ],
                 'ldflags': [
-                  '-fsanitize=address',
+                  '-faddress-sanitizer',
                 ],
                 'defines': [
                   'ADDRESS_SANITIZER',
@@ -3163,8 +3164,9 @@
               # Due to issues in Clang build system, using ASan on 32-bit
               # binaries on x86_64 host is problematic.
               # TODO(eugenis): re-enable.
-              '-fsanitize=address',
-              '-w',  # http://crbug.com/162783
+              '-faddress-sanitizer',
+              # See http://crbug.com/159580
+              '-w',
             ],
             'ldflags!': [
               '-faddress-sanitizer',
@@ -3285,8 +3287,9 @@
           ['asan==1', {
             'xcode_settings': {
               'OTHER_CFLAGS': [
-                '-fsanitize=address',
-                '-w',  # http://crbug.com/162783
+                '-faddress-sanitizer',
+                # See http://crbug.com/159580
+                '-w',
               ],
             },
             'defines': [