Address some TODO(GYP)s in the GN build.

Some were obsolete, some I implemented in this patch. Some I left as-is if they applied to Mac or iOS.

A few items are TODOs for when transition is complete. I changed these to "TODO(GYP_GONE)"

This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1953523002
Cr-Original-Commit-Position: refs/heads/master@{#391943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9427f9e3edb7be9bd540bb35b3d3156c08c3df6

config/BUILD.gn

@@ -13,7 +13,7 @@ import("//build/toolchain/goma.gni")
 
 # One common error that happens is that GYP-generated headers within gen/ get
 # included rather than the GN-generated ones within gen/ subdirectories.
-# TODO(agrieve): Remove once GYP is gone (as well as exec_script exception).
+# TODO(GYP_GONE): Remove once GYP is gone (as well as exec_script exception).
 assert(
     exec_script("//build/dir_exists.py", [ "obj.host" ], "string") == "False",
     "GYP artifacts detected in $root_build_dir.$0x0A" +
@@ -48,8 +48,8 @@ declare_args() {
 #
 # For now we define these globally to match the current GYP build.
 config("feature_flags") {
-  # TODO(brettw) this probably needs to be parameterized.
-  defines = [ "V8_DEPRECATION_WARNINGS" ]  # Don't use deprecated V8 APIs anywhere.
+  # Don't use deprecated V8 APIs anywhere.
+  defines = [ "V8_DEPRECATION_WARNINGS" ]
   if (enable_mdns) {
     defines += [ "ENABLE_MDNS=1" ]
   }
@@ -288,8 +288,6 @@ config("release") {
   defines = [ "NDEBUG" ]
 
   # Sanitizers.
-  # TODO(GYP) The GYP build has "release_valgrind_build == 0" for this
-  # condition. When Valgrind is set up, we need to do the same here.
   if (is_tsan) {
     defines += [
       "DYNAMIC_ANNOTATIONS_ENABLED=1",

config/android/rules.gni

@@ -2080,7 +2080,7 @@ template("instrumentation_test_apk") {
     }
   }
 
-  # TODO(GYP): Delete once recipes no longer use this target.
+  # TODO: Delete once recipes no longer use this target.
   group("${target_name}_run") {
     public_deps = [
       ":${invoker.target_name}",

config/compiler/BUILD.gn

@@ -45,7 +45,7 @@ declare_args() {
   # Requires profiling to be set to true.
   enable_full_stack_frames_for_profiling = false
 
-  # TODO(GYP): We should be using 64-bit gold for linking on both 64-bit Linux
+  # TODO: We should be using 64-bit gold for linking on both 64-bit Linux
   # and 32-bit linux; 32-bit Gold runs out of address-space on 32-bit builds.
   # However, something isn't quite working right on the 32-bit builds.
   use_gold =
@@ -1328,9 +1328,6 @@ config("optimize_max") {
 
       # TODO(thakis): Remove is_clang here, https://crbug.com/598772
       if (is_official_build && !is_clang) {
-        # TODO(GYP): TODO(dpranke): Should these only be on in an official
-        # build, or on all the time? For now we'll require official build so
-        # that the compile is clean.
         cflags += [
           "/GL",  # Whole program optimization.
 

gn_migration.gypi

@@ -14,9 +14,6 @@
 #
 # 'gyp_remaining' lists all of the targets that still need to be converted,
 # i.e., all of the other (non-empty) targets that a GYP build will build.
-#
-# TODO(GYP): crbug.com/481694. Add a build step to the bot that enforces the
-# above contracts.
 
 {
   'includes': [

secondary/third_party/crashpad/crashpad/util/BUILD.gn

@@ -228,7 +228,9 @@ source_set("util") {
       "/wd4577",  # 'noexcept' used with no exception handling mode specified.
     ]
 
-    # TODO(GYP) UseSafeExceptionHandlers masm rule.
+    if (current_cpu == "x86") {
+      asmflags = [ "/safeseh" ]
+    }
   } else if (is_mac) {
     sources += get_target_outputs(":mig")
     deps += [ ":mig" ]