From 0a09a4a4fbdb81212b9755ca62c94649351d1d00 Mon Sep 17 00:00:00 2001 From: "brettw@chromium.org" Date: Tue, 17 Dec 2013 00:02:45 +0000 Subject: [PATCH] Don't double-quote strings when passing them into GN args. Previously, both EscapeStringForGN and GetArgsStringForGN would add quotes. BUG= R=finnur@chromium.org Review URL: https://codereview.chromium.org/112853004 git-svn-id: http://src.chromium.org/svn/trunk/src/build@241075 4ff67af0-8c30-449e-8e8b-ad334ec8d88c --- gyp_chromium | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gyp_chromium b/gyp_chromium index 978ce4af5..e8aee14af 100755 --- a/gyp_chromium +++ b/gyp_chromium @@ -129,7 +129,7 @@ def GetArgsStringForGN(supplemental_files): # These string arguments get passed directly. for v in ['windows_sdk_path']: if v in vars_dict: - gn_args += ' ' + v + '="' + EscapeStringForGN(vars_dict[v]) + '"' + gn_args += ' ' + v + '=' + EscapeStringForGN(vars_dict[v]) # Set the GYP flag so BUILD files know they're being invoked in GYP mode. gn_args += ' is_gyp=true'