From 0ede8575d4576e68fa39ecb58a107bf822cf5f75 Mon Sep 17 00:00:00 2001 From: alexmos Date: Tue, 5 May 2015 17:23:12 -0700 Subject: [PATCH] Fix suppression for WindowProxy::initializeIfNeeded to match on release builds. Due to 484760, symbolization for WindowProxy::initializeIfNeeded is different between debug and release builds, which causes the current suppression to not match on the try bots. On release builds, it comes up as: > #8 0x7875c74 in initializeIfNeeded third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp:209:19 Use blink::WindowProxy::createContext instead. BUG=484760, 478792 NOTRY=true Review URL: https://codereview.chromium.org/1130603002 Cr-Original-Commit-Position: refs/heads/master@{#328447} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 8c214f63c675d641c31053ebd1c56688e774f557 --- sanitizers/lsan_suppressions.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sanitizers/lsan_suppressions.cc b/sanitizers/lsan_suppressions.cc index f9aae3ead..ac2defa11 100644 --- a/sanitizers/lsan_suppressions.cc +++ b/sanitizers/lsan_suppressions.cc @@ -59,7 +59,6 @@ char kLSanDefaultSuppressions[] = "leak:WTF::StringImpl::createUninitialized\n" "leak:WTF::StringImpl::create8BitIfPossible\n" "leak:blink::MouseEvent::create\n" -"leak:blink::WindowProxy::initializeIfNeeded\n" "leak:blink::*::*GetterCallback\n" "leak:blink::CSSComputedStyleDeclaration::create\n" "leak:blink::V8PerIsolateData::ensureDomInJSContext\n" @@ -69,6 +68,9 @@ char kLSanDefaultSuppressions[] = // This should really be RemoteDOMWindow::create, but symbolization is // weird in release builds. https://crbug.com/484760 "leak:blink::RemoteFrame::create\n" +// Likewise, this should really be blink::WindowProxy::initializeIfNeeded. +// https://crbug.com/484760 +"leak:blink::WindowProxy::createContext\n" // http://crbug.com/356785 "leak:content::RenderViewImplTest_DecideNavigationPolicyForWebUI_Test::TestBody\n"