From 10ea402dc76f04d8e85d8afc6dc9c038ec46655c Mon Sep 17 00:00:00 2001 From: vmpstr Date: Mon, 22 Aug 2016 10:07:16 -0700 Subject: [PATCH] build: Remove enabled-by-default check-implicit-copy-ctors flag. This flag is now enabled by default, so we don't need to specify it. Remove it from the build files. R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2260913002 Cr-Original-Commit-Position: refs/heads/master@{#413459} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 113b383d7cc3abfd48e4d8a6c318dc6c50d57d3f --- common.gypi | 3 +-- config/clang/BUILD.gn | 4 ---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/common.gypi b/common.gypi index 36fff0ddb..ab1be55fc 100644 --- a/common.gypi +++ b/common.gypi @@ -2225,8 +2225,7 @@ }], ], 'clang_plugin_args%': '-Xclang -plugin-arg-find-bad-constructs -Xclang check-templates ' - '-Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion ' - '-Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors ', + '-Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion ', }, # If you change these, also change build/config/clang/BUILD.gn. 'clang_chrome_plugins_flags%': diff --git a/config/clang/BUILD.gn b/config/clang/BUILD.gn index 64e467aca..f2c8c1660 100644 --- a/config/clang/BUILD.gn +++ b/config/clang/BUILD.gn @@ -43,10 +43,6 @@ config("find_bad_constructs") { "-plugin-arg-find-bad-constructs", "-Xclang", "follow-macro-expansion", - "-Xclang", - "-plugin-arg-find-bad-constructs", - "-Xclang", - "check-implicit-copy-ctors", ] if ((is_linux || is_android) && !is_chromecast) {