Enable warnings for having RefCounted types with a public destructor.

Enable the Clang error that makes it a warning/error to derive from
base::RefCounted/RefCountedThreadSafe directly and have a public
destructor for Linux and Mac builds.

For ChromeOS builds, do not yet enable the warning, as it does not
yet build cleanly.

BUG=123295
TEST=it compiles
R=thakis


Review URL: https://chromiumcodereview.appspot.com/10414016

git-svn-id: http://src.chromium.org/svn/trunk/src/build@138031 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

common.gypi

@@ -1089,8 +1089,28 @@
         'grit_defines': ['-D', 'enable_extensions'],
       }],
       ['clang_use_chrome_plugins==1 and OS!="win"', {
-        'clang_chrome_plugins_flags':
+        'variables': {
-            '<!(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)',
+          'clang_chrome_plugins_flags': [
+            '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
+          ],
+        },
+        'conditions': [
+          ['chromeos==1', {
+            # TODO(rsleevi): http://crbug.com/123295 - Disabled on ChromeOS
+            # for now.
+            'clang_chrome_plugins_flags': [
+              '<@(clang_chrome_plugins_flags)',
+              '-Xclang',
+              '-plugin-arg-find-bad-constructs',
+              '-Xclang',
+              '-skip-refcounted-dtors'
+            ],
+          }, {
+            'clang_chrome_plugins_flags': [
+              '<@(clang_chrome_plugins_flags)',
+            ],
+          }],
+        ],
       }],
 
       # Set use_ibus to 1 to enable ibus support.
@@ -2191,7 +2211,7 @@
           }],
           ['clang==1 and clang_use_chrome_plugins==1', {
             'cflags': [
-              '<(clang_chrome_plugins_flags)',
+              '<@(clang_chrome_plugins_flags)',
             ],
           }],
           ['clang==1 and clang_load!=""', {
@@ -2626,7 +2646,7 @@
             }],
             ['clang==1 and clang_use_chrome_plugins==1', {
               'OTHER_CFLAGS': [
-                '<(clang_chrome_plugins_flags)',
+                '<@(clang_chrome_plugins_flags)',
               ],
             }],
             ['clang==1 and clang_load!=""', {