From 1f27ec197f4fafd6df5fc01c1ea12a6cb355a21d Mon Sep 17 00:00:00 2001 From: bshe Date: Wed, 16 Nov 2016 19:26:58 -0800 Subject: [PATCH] Reland of Enable WebVR for non component build (patchset #1 id:1 of https://codereview.chromium.org/2505963003/ ) Reason for revert: Hi Andrew. It turns out that our UX review is blocked on this. We need it in canary build. I will revert your revert for now. And I will work with you tomorrow to figure out if there is a way to reduce dex size of gvr. There should be enough time to land/merge these improvements before it hits stable. Anyway, let's talk tomorrow. Thanks! Original issue's description: > Revert of Enable WebVR for non component build (patchset #5 id:80001 of https://codereview.chromium.org/2502643002/ ) > > Reason for revert: > Reverting until dex size growth is understood. > > Original issue's description: > > Enable Android WebVR for arm & arm64 > > > > BUG=644785 > > > > Committed: https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898 > > Cr-Commit-Position: refs/heads/master@{#432489} > > TBR=bshe@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=644785 > > Committed: https://crrev.com/19ef7689f208ee3222539bf0bb1d4054b2dbf780 > Cr-Commit-Position: refs/heads/master@{#432606} TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644785 Review-Url: https://codereview.chromium.org/2505313002 Cr-Original-Commit-Position: refs/heads/master@{#432723} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: eabd2c4458bf716a84e060d3d80e3d931dfa69d7 --- config/features.gni | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/config/features.gni b/config/features.gni index ee7441a98..8154154c3 100644 --- a/config/features.gni +++ b/config/features.gni @@ -82,8 +82,7 @@ declare_args() { # Still requires command line flag to access API # TODO(bshe): Enable for other architecture too. Currently we only support arm # and arm64. - enable_webvr = is_android && is_component_build && - (current_cpu == "arm" || current_cpu == "arm64") + enable_webvr = is_android && (current_cpu == "arm" || current_cpu == "arm64") } # Additional dependent variables -----------------------------------------------