Add comment warning about modifying landmines
Modifying landmines has greater consequences than is sometimes realized for developers, especially on Windows. Add a comment to warn editors of these consequences. R=dpranke@chromium.org BUG=736939 Review-Url: https://codereview.chromium.org/2960013002 Cr-Original-Commit-Position: refs/heads/master@{#483579} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: a1ed2e02283cf828822dd24dd0e8f5e22767b4bc
This commit is contained in:
Родитель
b2a8c41928
Коммит
259d8497c4
|
@ -28,6 +28,16 @@ def print_landmines():
|
|||
# need to be cleaned up. If you're writing a new CL that causes build
|
||||
# dependency problems, fix the dependency problems instead of adding a
|
||||
# landmine.
|
||||
#
|
||||
# Before adding or changing a landmine consider the consequences of doing so.
|
||||
# Doing so will wipe out every output directory on every Chrome developer's
|
||||
# machine. This can be particularly problematic on Windows where the directory
|
||||
# deletion may well fail (locked files, command prompt in the directory,
|
||||
# etc.), and generated .sln and .vcxproj files will be deleted.
|
||||
#
|
||||
# This output directory deletion will be repeated when going back and forth
|
||||
# across the change that added the landmine, adding to the cost. There are
|
||||
# usually less troublesome alternatives.
|
||||
|
||||
if distributor() == 'goma' and platform() == 'win32':
|
||||
print 'Need to clobber winja goma due to backend cwd cache fix.'
|
||||
|
|
Загрузка…
Ссылка в новой задаче