From 26f0866b0462a6a4854ac4f4877658bfa978f7f4 Mon Sep 17 00:00:00 2001 From: thakis Date: Fri, 10 Jun 2016 11:47:50 -0700 Subject: [PATCH] gn: Add chromium_builder_asan target. All the LKGR clusterfuzz bots build this target, so add it to allow switching these bots to gn. BUG=618702,542853,619086 TBR=eroman Review-Url: https://codereview.chromium.org/2059843002 Cr-Original-Commit-Position: refs/heads/master@{#399241} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 3f7d4fc75b62ca7008642c5aea6233eade695da5 --- all.gyp | 1 + sanitizers/BUILD.gn | 3 +-- sanitizers/sanitizers.gyp | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/all.gyp b/all.gyp index 10c53212e..73484f213 100644 --- a/all.gyp +++ b/all.gyp @@ -708,6 +708,7 @@ '../third_party/pdfium/samples/samples.gyp:pdfium_test', ], }], + # TODO(thakis): Remove this block, nothing ever sets this. ['internal_filter_fuzzer==1', { 'dependencies': [ '../skia/tools/clusterfuzz-data/fuzzers/filter_fuzzer/filter_fuzzer.gyp:filter_fuzzer', diff --git a/sanitizers/BUILD.gn b/sanitizers/BUILD.gn index 4f81f3eba..40ffcb746 100644 --- a/sanitizers/BUILD.gn +++ b/sanitizers/BUILD.gn @@ -2,8 +2,7 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -if (is_linux && !is_chromeos) { - # TODO(GYP): Figure out which of these work and are needed on other platforms. +if (is_clang) { copy("copy_llvm_symbolizer") { if (is_win) { sources = [ diff --git a/sanitizers/sanitizers.gyp b/sanitizers/sanitizers.gyp index 91dab8a23..025348ec3 100644 --- a/sanitizers/sanitizers.gyp +++ b/sanitizers/sanitizers.gyp @@ -66,6 +66,7 @@ ], }, }, + # GN version: //build/sanitizers:copy_llvm_symbolizer { # Copy llvm-symbolizer to the product dir so that LKGR bots can package it. 'target_name': 'llvm-symbolizer',