From 305a5c07835441af607b73989bc6122b3554fe3c Mon Sep 17 00:00:00 2001 From: Wez Date: Mon, 28 Oct 2019 18:48:00 +0000 Subject: [PATCH] [fuchsia] Enable shadow-call-stack for all targets. Bug: fuchsia:27339, 821951 Change-Id: If685fd9817f8dae8671634f3798a655ddb2ba392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863774 Auto-Submit: Wez Commit-Queue: Kevin Marshall Reviewed-by: Kevin Marshall Cr-Original-Commit-Position: refs/heads/master@{#709978} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: f1bb41bdc78a389634aae97914ea93d071524c52 --- config/fuchsia/BUILD.gn | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/config/fuchsia/BUILD.gn b/config/fuchsia/BUILD.gn index 9a0ca692f..56d79f417 100644 --- a/config/fuchsia/BUILD.gn +++ b/config/fuchsia/BUILD.gn @@ -51,7 +51,11 @@ config("compiler") { # TODO(crbug.com/821951): Clang enables SafeStack by default when targeting # Fuchsia, but it breaks some tests, notably in V8. - cflags += [ "-fno-sanitize=safe-stack" ] + # Force the toolchain to use shadow-call-stack instead, until that is default. + cflags += [ + "-fno-sanitize=safe-stack", + "-fsanitize=shadow-call-stack", + ] libs = [ "zircon" ] }