linux: don't define NO_HEAPCHECKER for every file

Rather than globally defining NO_HEAPCHECKER and then checking
that in build_config.h, let builds that opt in to heap checking
directly set USE_HEAPCHECKER.

Result should be equivalent builds but less stuff in the build
files.


Review URL: http://codereview.chromium.org/9146022

git-svn-id: http://src.chromium.org/svn/trunk/src/build@118823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

build_config.h

@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
@@ -71,11 +71,6 @@
 #define USE_TCMALLOC 1
 #endif
 
-// Use heapchecker.
-#if defined(OS_LINUX) && !defined(NO_HEAPCHECKER)
-#define USE_HEAPCHECKER 1
-#endif
-
 // Compiler detection.
 #if defined(__GNUC__)
 #define COMPILER_GCC 1

common.gypi

@@ -2046,13 +2046,11 @@
           }],
           ['linux_use_heapchecker==1', {
             'variables': {'linux_use_tcmalloc%': 1},
+            'defines': ['USE_HEAPCHECKER'],
           }],
           ['linux_use_tcmalloc==0', {
             'defines': ['NO_TCMALLOC'],
           }],
-          ['linux_use_heapchecker==0', {
-            'defines': ['NO_HEAPCHECKER'],
-          }],
           ['linux_keep_shadow_stacks==1', {
             'defines': ['KEEP_SHADOW_STACKS'],
             'cflags': ['-finstrument-functions'],