Enable in-process symbolization by default.

R=kcc@chromium.org,glider@chromium.org
TBR=kcc@chromium.org

Review-Url: https://codereview.chromium.org/2023033002
Cr-Original-Commit-Position: refs/heads/master@{#397010}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 87981e75530ab455e12475535857613c927fa6ba

sanitizers/sanitizer_options.cc

@@ -39,9 +39,7 @@ void _sanitizer_options_link_helper() { }
 //     for each malloc/free by 5 frames. These stack traces tend to accumulate
 //     very fast in applications using JIT (v8 in Chrome's case), see
 //     https://code.google.com/p/address-sanitizer/issues/detail?id=177
-//   symbolize=false - disable the in-process symbolization, which isn't 100%
-//     compatible with the existing sandboxes and doesn't make much sense for
-//     stripped official binaries.
+//   symbolize=1 - enable in-process symbolization.
 //   legacy_pthread_cond=1 - run in the libpthread 2.2.5 compatibility mode to
 //     work around libGL.so using the obsolete API, see
 //     http://crbug.com/341805. This may break if pthread_cond_t objects are
@@ -55,7 +53,6 @@ void _sanitizer_options_link_helper() { }
 //     for stack overflow detection.
 //   strip_path_prefix=Release/../../ - prefixes up to and including this
 //     substring will be stripped from source file paths in symbolized reports
-//     (if symbolize=true, which is set when running with LeakSanitizer).
 //   fast_unwind_on_fatal=1 - use the fast (frame-pointer-based) stack unwinder
 //     to print error reports. V8 doesn't generate debug info for the JIT code,
 //     so the slow unwinder may not work properly.
@@ -68,12 +65,12 @@ void _sanitizer_options_link_helper() { }
 // Chromium builds.
 const char kAsanDefaultOptions[] =
     "legacy_pthread_cond=1 malloc_context_size=5 "
-    "symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 "
+    "symbolize=1 check_printf=1 use_sigaltstack=1 detect_leaks=0 "
     "strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
 #else
 // Default AddressSanitizer options for buildbots and non-official builds.
 const char *kAsanDefaultOptions =
-    "symbolize=false check_printf=1 use_sigaltstack=1 "
+    "symbolize=1 check_printf=1 use_sigaltstack=1 "
     "detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1 "
     "detect_stack_use_after_return=1 ";
 #endif  // GOOGLE_CHROME_BUILD