Revert of Enable noexcept on Windows, use for a few move constructors. (patchset #3 id:40001 of https://codereview.chromium.org/2771643002/ )
Reason for revert:
Seems to have broken Windows build with args.gn as:
> is_debug = true
> is_component_build = true
> enable_nacl = false
> is_chrome_branded = true
> symbol_level = 2
> target_cpu = "x86"
> is_win_fastlink = true
> is_clang = false
> win_console_app = true
> win_linker_timing = true
Original issue's description:
> Enable noexcept on Windows, use for a few move constructors.
>
> MSVC complains if you use noexcept with no exception handling mode specified (as we do).
> This code disables the warning. noexcept on move constructors allows better optimizations
> in some cases.
> http://en.cppreference.com/w/cpp/language/noexcept_spec
>
> Updates a few common classes' move constructors to use this.
>
> Review-Url: https://codereview.chromium.org/2771643002
> Cr-Commit-Position: refs/heads/master@{#458956}
> Committed: 76aac97386
TBR=brucedawson@chromium.org,lfg@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2769703007
Cr-Original-Commit-Position: refs/heads/master@{#459101}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 12c27f45b2cd8fea6c833a47d5270da42d791740
This commit is contained in:
Родитель
568ed23e5f
Коммит
6252d1e0e5
|
@ -303,11 +303,17 @@ config("compiler") {
|
|||
# ---------------------------------
|
||||
if (is_linux || is_android) {
|
||||
if (use_pic) {
|
||||
cflags += [ "-fPIC" ]
|
||||
ldflags += [ "-fPIC" ]
|
||||
cflags += [
|
||||
"-fPIC",
|
||||
]
|
||||
ldflags += [
|
||||
"-fPIC",
|
||||
]
|
||||
}
|
||||
|
||||
cflags += [ "-pipe" ] # Use pipes for communicating between sub-processes. Faster.
|
||||
cflags += [
|
||||
"-pipe", # Use pipes for communicating between sub-processes. Faster.
|
||||
]
|
||||
|
||||
ldflags += [
|
||||
"-Wl,-z,noexecstack",
|
||||
|
@ -899,10 +905,6 @@ config("default_warnings") {
|
|||
# This is necessary for the shared library build.
|
||||
"/wd4251",
|
||||
|
||||
# C4312 is a VS 2015 64-bit warning for integer to larger pointer.
|
||||
# TODO(brucedawson): fix warnings, crbug.com/554200
|
||||
"/wd4312",
|
||||
|
||||
# C4351: new behavior: elements of array 'array' will be default
|
||||
# initialized
|
||||
# This is a silly "warning" that basically just alerts you that the
|
||||
|
@ -965,10 +967,10 @@ config("default_warnings") {
|
|||
"/wd4459",
|
||||
]
|
||||
|
||||
cflags_cc += [
|
||||
# Allow "noexcept" annotations even though we compile with exceptions
|
||||
# disabled.
|
||||
"/wd4577",
|
||||
cflags += [
|
||||
# C4312 is a VS 2015 64-bit warning for integer to larger pointer.
|
||||
# TODO(brucedawson): fix warnings, crbug.com/554200
|
||||
"/wd4312",
|
||||
]
|
||||
|
||||
if (current_cpu == "x86") {
|
||||
|
|
Загрузка…
Ссылка в новой задаче