From 64080bbc1a761255dc2795555f73382e06459649 Mon Sep 17 00:00:00 2001 From: jkarlin Date: Fri, 31 Jul 2015 10:04:08 -0700 Subject: [PATCH] Remove a race around NetworkChangeNotifier::test_notifications_only_ There is a possible race in which NetworkChangeNotifier::test_notifications_only_ might be read on one thread while being written on another. This CL fixes that by making the variable static and only allowing writes to it before the NetworkChangeNotifier is created (before other things might try to read it). BUG=454652 Review URL: https://codereview.chromium.org/1255263002 Cr-Original-Commit-Position: refs/heads/master@{#341354} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: e160f6be485deabcb4725d7e3623ae18ef5aee48 --- sanitizers/tsan_suppressions.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/sanitizers/tsan_suppressions.cc b/sanitizers/tsan_suppressions.cc index f3b2e3d20..cca88d0c5 100644 --- a/sanitizers/tsan_suppressions.cc +++ b/sanitizers/tsan_suppressions.cc @@ -292,9 +292,6 @@ char kTSanDefaultSuppressions[] = // https://crbug.com/448203 "race:blink::RemoteFrame::detach\n" -// https://crbug.com/454652 -"race:net::NetworkChangeNotifier::SetTestNotificationsOnly\n" - // https://crbug.com/455638 "deadlock:dbus::Bus::ShutdownAndBlock\n"