Android: Use lint from cmdline-tools

This version of lint is up-to-date with Android Studio and the lint team
intends to keep it that way.

We no longer need a separate tools-lint directory for an up-to-date
version of lint.

Bug: 1069186
Change-Id: I8846406c4787d36863718489c3c54c4b1438d79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144367
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#758085}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cce3bf4ac3463036d054929a78f94a0ddfeca4d0

android/lint/suppressions.xml

@@ -22,6 +22,12 @@ Still reading?
   Note: PRODUCT_DIR will be substituted at run-time with actual
   directory path (e.g. out/Debug)
 -->
+  <issue id="AcceptsUserCertificates">
+    <!-- See https://crbug.com/827265 and comment in the file for context. -->
+    <ignore regexp="chrome/android/java/res/xml/network_security_config.xml"/>
+    <ignore regexp="android_webview/tools/system_webview_shell/apk/res/xml/network_security_config.xml"/>
+    <ignore regexp="test"/>
+  </issue>
   <!-- AllowBackup defaults to true, and causes a lint warning if not explicitly set. -->
   <issue id="AllowBackup">
     <ignore path="AndroidManifest.xml"/>
@@ -32,6 +38,7 @@ Still reading?
   <issue id="Assert" severity="ignore"/>
   <issue id="AuthLeak" severity="Error">
     <ignore regexp="chrome/android/javatests"/>
+    <ignore regexp="Test.java"/>
   </issue>
   <issue id="BadHostnameVerifier" severity="Error"/>
   <issue id="ButtonOrder" severity="Error">
@@ -166,6 +173,12 @@ Still reading?
     <ignore regexp="chrome/browser/ui/android/strings/ui_strings_grd"/>
     <ignore regexp="components/browser_ui/strings/android/browser_ui_strings_grd"/>
   </issue>
+  <issue id="InsecureBaseConfiguration">
+    <!-- See https://crbug.com/827265 and comment in the file for context. -->
+    <ignore regexp="chrome/android/java/res/xml/network_security_config.xml"/>
+    <ignore regexp="android_webview/tools/system_webview_shell/apk/res/xml/network_security_config.xml"/>
+    <ignore regexp="test"/>
+  </issue>
   <issue id="InconsistentArrays" severity="Error">
     <ignore regexp="android_webview/locale_paks.resources.zip/values/locale-paks.xml"/>
     <ignore regexp="chrome/android/chrome_locale_paks.resources.zip/values/locale-paks.xml"/>
@@ -279,6 +292,10 @@ Still reading?
   <issue id="OldTargetApi">
     <ignore path="AndroidManifest.xml"/>
   </issue>
+  <issue id="OnClick">
+    <!-- False positive, see: http://issuetracker.google.com/148523770 for similar issue. -->
+    <ignore path="tools/android/audio_focus_grabber/java/res/layout/audio_focus_grabber_activity.xml"/>
+  </issue>
   <issue id="Overdraw" severity="ignore"/>
   <issue id="PackageManagerGetSignatures">
     <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java"/>

config/android/internal_rules.gni

@@ -862,7 +862,7 @@ if (enable_java_templates) {
       if (defined(invoker.min_sdk_version)) {
         _min_sdk_version = invoker.min_sdk_version
       }
-      _lint_path = "$lint_android_sdk_root/tools-lint/bin/lint"
+      _lint_path = "$lint_android_sdk_root/cmdline-tools/latest/bin/lint"
       _cache_dir = "$root_build_dir/android_lint_cache"
       _result_path = "$target_out_dir/$target_name/result.xml"
       _config_path = "$target_out_dir/$target_name/config.xml"
@@ -874,6 +874,7 @@ if (enable_java_templates) {
       script = "//build/android/gyp/lint.py"
       depfile = "$target_gen_dir/$target_name.d"
       inputs = [
+        _lint_path,
         _platform_xml_path,
         _suppressions_file,
       ]