extract_build failure should be fatal
This code has been here since this script was created back in bug 154525, however these days the warning code is 88. Maybe the warning code has always been 88, but its always been OK for an extract_build step to be non-fatal. I would be happy to test this if someone could explain to me how this file is tested. These days we expect extract_build to fail the build, if it doesn't then we just go and run test with the wrong revision, etc. BUG=397710, 154525 Review URL: https://codereview.chromium.org/416243007 git-svn-id: http://src.chromium.org/svn/trunk/src/build@285914 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
Родитель
d51cf1db99
Коммит
81b9283411
|
@ -75,8 +75,7 @@ def ZipBuild(options):
|
|||
def ExtractBuild(options):
|
||||
bb_annotations.PrintNamedStep('extract_build')
|
||||
RunCmd([os.path.join(SLAVE_SCRIPTS_DIR, 'extract_build.py')]
|
||||
+ bb_utils.EncodeProperties(options),
|
||||
warning_code=1, cwd=DIR_BUILD_ROOT)
|
||||
+ bb_utils.EncodeProperties(options), cwd=DIR_BUILD_ROOT)
|
||||
|
||||
|
||||
def FindBugs(options):
|
||||
|
|
Загрузка…
Ссылка в новой задаче