From 81d5adc244465c71f8916b0d828fb59701619a6c Mon Sep 17 00:00:00 2001
From: "ilevy@chromium.org"
 <ilevy@chromium.org@4ff67af0-8c30-449e-8e8b-ad334ec8d88c>
Date: Thu, 21 Nov 2013 13:48:58 +0000
Subject: [PATCH] Fix android presubmit errors.

Modify android code to avoid depending on side effects of previous
steps when in BUILDBOT_TESTING mode.  This is causing failure on
chromium_presubmit.  Fix some pylint warnings.

BUG=317585

Review URL: https://codereview.chromium.org/59903026

git-svn-id: http://src.chromium.org/svn/trunk/src/build@236522 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
---
 android/adb_logcat_printer.py       | 26 ++++++++++++++++++--------
 android/buildbot/bb_device_steps.py |  7 ++-----
 2 files changed, 20 insertions(+), 13 deletions(-)

diff --git a/android/adb_logcat_printer.py b/android/adb_logcat_printer.py
index 5194668ec..8e69a2c41 100755
--- a/android/adb_logcat_printer.py
+++ b/android/adb_logcat_printer.py
@@ -20,6 +20,7 @@ monitoring for the deletion of the aforementioned file.
 
 import cStringIO
 import logging
+import optparse
 import os
 import re
 import signal
@@ -52,7 +53,7 @@ def CombineLogFiles(list_of_lists, logger):
       try:
         line = cur_device_log[-1]
         # Used to make sure we only splice on a timestamped line
-        if re.match('^\d{2}-\d{2} \d{2}:\d{2}:\d{2}.\d{3} ', line):
+        if re.match(r'^\d{2}-\d{2} \d{2}:\d{2}:\d{2}.\d{3} ', line):
           common_index = cur_file_lines.index(line)
         else:
           logger.warning('splice error - no timestamp in "%s"?', line.strip())
@@ -76,7 +77,7 @@ def FindLogFiles(base_dir):
   Returns:
     Mapping of device_id to a sorted list of file paths for a given device
   """
-  logcat_filter = re.compile('^logcat_(\w+)_(\d+)$')
+  logcat_filter = re.compile(r'^logcat_(\w+)_(\d+)$')
   # list of tuples (<device_id>, <seq num>, <full file path>)
   filtered_list = []
   for cur_file in os.listdir(base_dir):
@@ -87,7 +88,7 @@ def FindLogFiles(base_dir):
   filtered_list.sort()
   file_map = {}
   for device_id, _, cur_file in filtered_list:
-    if not device_id in file_map:
+    if device_id not in file_map:
       file_map[device_id] = []
 
     file_map[device_id] += [cur_file]
@@ -149,7 +150,19 @@ def ShutdownLogcatMonitor(base_dir, logger):
     logger.exception('Error signaling logcat monitor - continuing')
 
 
-def main(base_dir, output_file):
+def main(argv):
+  parser = optparse.OptionParser(usage='Usage: %prog [options] <log dir>')
+  parser.add_option('--output-path',
+                    help='Output file path (if unspecified, prints to stdout)')
+  options, args = parser.parse_args(argv)
+  if len(args) != 1:
+    parser.error('Wrong number of unparsed args')
+  base_dir = args[0]
+  if options.output_path:
+    output_file = open(options.output_path, 'w')
+  else:
+    output_file = sys.stdout
+
   log_stringio = cStringIO.StringIO()
   logger = logging.getLogger('LogcatPrinter')
   logger.setLevel(LOG_LEVEL)
@@ -196,7 +209,4 @@ def main(base_dir, output_file):
   output_file.write(log_stringio.getvalue())
 
 if __name__ == '__main__':
-  if len(sys.argv) == 1:
-    print 'Usage: %s <base_dir>' % sys.argv[0]
-    sys.exit(1)
-  sys.exit(main(sys.argv[1], sys.stdout))
+  sys.exit(main(sys.argv[1:]))
diff --git a/android/buildbot/bb_device_steps.py b/android/buildbot/bb_device_steps.py
index 80342f298..d9424c0a5 100755
--- a/android/buildbot/bb_device_steps.py
+++ b/android/buildbot/bb_device_steps.py
@@ -511,11 +511,8 @@ def LogcatDump(options):
   # Print logcat, kill logcat monitor
   bb_annotations.PrintNamedStep('logcat_dump')
   logcat_file = os.path.join(CHROME_OUT_DIR, options.target, 'full_log')
-  with open(logcat_file, 'w') as f:
-    RunCmd([
-        os.path.join(CHROME_SRC_DIR, 'build', 'android',
-                     'adb_logcat_printer.py'),
-        LOGCAT_DIR], stdout=f)
+  RunCmd([SrcPath('build' , 'android', 'adb_logcat_printer.py'),
+          '--output-path', logcat_file, LOGCAT_DIR])
   RunCmd(['cat', logcat_file])