This caused failures in ui_unittests FontListTest.Fonts_GetHeight_GetBaseline
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=30356 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=13543 Revert 211664 "Shows Japanese and English mixed queries correctly." > Shows Japanese and English mixed queries correctly. > > This CL respects the common height and baseline of the fonts in the given font list, and draw text according to the baseline. > > The cause of vertically-misaligned queries was that > 1. ASCII characters have 23 pixels in height > 2. Japanese characters have 17 pixels in height > > pango_layout_get_pixel_size(), which is called in RenderTextLinux::GetStringSize(), returns the above size. > > Also see: > https://docs.google.com/a/chromium.org/document/d/1e2n9lEM_usn37Pld8tMeo_qpfLRQQjkx-O1hTHi3sPo/edit?usp=sharing > > BUG=244323 > TEST=Test manually. > > Review URL: https://chromiumcodereview.appspot.com/18848002 TBR=yukishiino@chromium.org Review URL: https://codereview.chromium.org/19270002 git-svn-id: http://src.chromium.org/svn/trunk/src/build@211669 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
Родитель
26e4193b35
Коммит
8cfaad75d1
|
@ -16,7 +16,6 @@ FontListTest.Fonts_FromDescStringWithStyleInFlexibleFormat
|
|||
FontListTest.Fonts_FromFont
|
||||
FontListTest.Fonts_FromFontVector
|
||||
FontListTest.Fonts_FromFontWithNonNormalStyle
|
||||
FontListTest.Fonts_GetHeight_GetBaseline
|
||||
FontListTest.Fonts_GetStyle
|
||||
FontTest.Ascent
|
||||
FontTest.AvgCharWidth
|
||||
|
@ -31,10 +30,10 @@ TextEliderTest.ElideEmailMoreSpace
|
|||
TextEliderTest.ElideRectangleText
|
||||
TextEliderTest.ElideRectangleTextLongWords
|
||||
TextEliderTest.ElideRectangleTextPunctuation
|
||||
TextEliderTest.ElideTextEllipsis
|
||||
TextEliderTest.ElideTextLongStrings
|
||||
TextEliderTest.ElideTextSurrogatePairs
|
||||
TextEliderTest.ElideTextTruncate
|
||||
TextEliderTest.ElideTextEllipsis
|
||||
TextEliderTest.TestFileURLEliding
|
||||
TextEliderTest.TestFilenameEliding
|
||||
TextEliderTest.TestGeneralEliding
|
||||
|
|
Загрузка…
Ссылка в новой задаче