Turn off PIE when building for Valgrind.

BUG=90221, 93551
TEST=Valgrind
Review URL: http://codereview.chromium.org/7724002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@98046 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

common.gypi

@@ -1688,10 +1688,24 @@
                   # relativization during dict merging.
                   'change_mach_o_flags_path':
                       'mac/change_mach_o_flags_from_xcode.sh',
+                  'change_mach_o_flags_options': [
+                  ],
+                  'target_conditions': [
+                    ['release_valgrind_build==1', {
+                      'change_mach_o_flags_options': [
+                        # Turn off PIE when building for Valgrind because
+                        # Valgrind doesn't understand slide. TODO: Make
+                        # Valgrind on Mac OS X understand slide, and get rid
+                        # of the Valgrind check.
+                        '--no-pie',
+                      ],
+                    }],
+                  ],
                 },
                 'postbuild_name': 'Change Mach-O Flags',
                 'action': [
                   '<(change_mach_o_flags_path)',
+                  '>@(change_mach_o_flags_options)',
                 ],
               },
             ],

mac/change_mach_o_flags_from_xcode.sh

@@ -11,4 +11,5 @@
 set -e
 
 exec "$(dirname "${0}")/change_mach_o_flags.py" \
+     "${@}" \
      "${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}"