Revert 62529 - Add -Wno-non-virtual-dtor flag on posix targets.
I got my double negatives incorrect, this should have been -Wnon-virtual-dtor. BUG=45135 TEST=Targets build without error. Review URL: http://codereview.chromium.org/3527003 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3756003 git-svn-id: http://src.chromium.org/svn/trunk/src/build@62531 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
Родитель
11996046bf
Коммит
a2e633b04f
|
@ -874,7 +874,6 @@
|
||||||
# Make inline functions have hidden visiblity by default.
|
# Make inline functions have hidden visiblity by default.
|
||||||
# Surprisingly, not covered by -fvisibility=hidden.
|
# Surprisingly, not covered by -fvisibility=hidden.
|
||||||
'-fvisibility-inlines-hidden',
|
'-fvisibility-inlines-hidden',
|
||||||
'-Wno-non-virtual-dtor',
|
|
||||||
],
|
],
|
||||||
'ldflags': [
|
'ldflags': [
|
||||||
'-pthread', '-Wl,-z,noexecstack',
|
'-pthread', '-Wl,-z,noexecstack',
|
||||||
|
@ -1238,11 +1237,6 @@
|
||||||
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
|
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
|
||||||
'GCC_VERSION': '4.2',
|
'GCC_VERSION': '4.2',
|
||||||
'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
|
'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
|
||||||
# TODO(cbentzel): http://crbug.com/45135
|
|
||||||
# Enable non virtual destructor warning on OSX.
|
|
||||||
# It's gcc implementation currently warns about more violations
|
|
||||||
# than Linux's gcc implementation.
|
|
||||||
#'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wno-non-virtual-dtor
|
|
||||||
# MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
|
# MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min
|
||||||
'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
|
'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)',
|
||||||
'PREBINDING': 'NO', # No -Wl,-prebind
|
'PREBINDING': 'NO', # No -Wl,-prebind
|
||||||
|
|
Загрузка…
Ссылка в новой задаче