Make GN components static libraries on Win x64
For the static builds, previously there was a static library exception for the windows official builds. They were source sets instead on the theory that some of them could get over 2GB. There's only one component over 2GB (blink_modules). The rest of the targets that were too large before were all explicit static libraries which have been dealt with already. This change whitelists blink_modules. After that, the largest static library is now blink_platform (1.2GB). The rest are less than 1 GB. So we can now disable the special case for this configuration. BUG=619949 Review-Url: https://codereview.chromium.org/2098673002 Cr-Original-Commit-Position: refs/heads/master@{#401800} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d28aba56dde82051680f9048daf1b1501b9bd89a
This commit is contained in:
Родитель
eef98eaf49
Коммит
b43dfcc6f4
|
@ -633,15 +633,10 @@ template("component") {
|
|||
assert(invoker.static_component_type == "static_library" ||
|
||||
invoker.static_component_type == "source_set")
|
||||
_component_mode = invoker.static_component_type
|
||||
} else if (!defined(invoker.sources) || is_mac ||
|
||||
(is_win && is_official_build)) {
|
||||
} else if (!defined(invoker.sources) || is_mac) {
|
||||
# When there are no sources defined, use a source set to avoid creating
|
||||
# an empty static library (which generally don't work).
|
||||
#
|
||||
# On Windows official builds, the link time code generation bloats static
|
||||
# libraries to the point where some of them become >32 bits large which
|
||||
# causes lib.exe to fail. Always use source sets for that configuration.
|
||||
#
|
||||
# TODO(brettw) bug 618797: Remove the mac condition. On Mac making these as
|
||||
# static_library causes crashes. Remove the mac condition above when this
|
||||
# is fixed.
|
||||
|
|
Загрузка…
Ссылка в новой задаче