Change _ITERATOR_DEBUG_LEVEL to 1 on Release builds

VS2010 changed the default to 0 meaning weaker checks in our
release builds.  This commit changes it back again.

BUG=289691

Review URL: https://codereview.chromium.org/23464081

git-svn-id: http://src.chromium.org/svn/trunk/src/build@229222 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

common.gypi

@@ -1704,6 +1704,7 @@
         'win_debug_disable_iterator_debugging': '1',
         'win_debug_Optimization': '1',
         'win_debug_InlineFunctionExpansion': '0',
+        'win_release_disable_iterator_debugging': '1',
         'win_release_InlineFunctionExpansion': '0',
         'win_release_OmitFramePointers': '0',
 
@@ -1721,8 +1722,9 @@
         # These runtime checks force initialization of stack vars which blocks
         # DrMemory's uninit detection.
         'win_debug_RuntimeChecks': '0',
-        # Iterator debugging is slow.
+        # Iterator debugging is slow. Disable in both Debug and Release
         'win_debug_disable_iterator_debugging': '1',
+        'win_release_disable_iterator_debugging': '1',
         # Try to disable optimizations that mess up stacks in a release build.
         # DrM-i#1054 (http://code.google.com/p/drmemory/issues/detail?id=1054)
         # /O2 and /Ob0 (disable inline) cannot be used together because of a
@@ -1846,6 +1848,11 @@
       # See http://msdn.microsoft.com/en-us/library/aa985982(v=VS.80).aspx
       'win_debug_disable_iterator_debugging%': '0',
 
+      # We now enable partial iterator debugging on Release builds but
+      # we want to make it disablable for release tsan and drmemory builds
+      # see http://crbug.com/289691
+      'win_release_disable_iterator_debugging%': '0',
+
       # An application manifest fragment to declare compatibility settings for
       # 'executable' targets. Ignored in other target type.
       'win_exe_compatibility_manifest%':
@@ -2668,6 +2675,13 @@
                 # "/Oy /Oy-" and warnings about overriding.
                 'AdditionalOptions': ['/Oy-'],
               }],
+              ['win_release_disable_iterator_debugging!=1', {
+                # VS2010 changed default _ITERATOR_DEBUG_LEVEL to 0
+                # on Release builds so we change it back to 1 to restore these
+                # checks, except if explicitly disabled
+                # See http://crbug.com/289691
+                'PreprocessorDefinitions': ['_ITERATOR_DEBUG_LEVEL=1'],
+              }],
             ],
             'AdditionalOptions': [ '<@(win_release_extra_cflags)', ],
           },