Use fast_unwind_on_fatal=1 by default in ASan builds.

This'll help us avoid crashes in the slow unwinder when unvinding through
V8-generated code.

BUG=422698
R=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/668343002

Cr-Original-Commit-Position: refs/heads/master@{#300780}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6744839e1f3d6c8abe49e685e9bfcb91c4abb154
This commit is contained in:
glider 2014-10-22 15:26:06 -07:00 коммит произвёл Commit bot
Родитель ef559c1459
Коммит bbf4921feb
1 изменённых файлов: 6 добавлений и 3 удалений

Просмотреть файл

@ -46,6 +46,9 @@ void _sanitizer_options_link_helper() { }
// strip_path_prefix=Release/../../ - prefixes up to and including this
// substring will be stripped from source file paths in symbolized reports
// (if symbolize=true, which is set when running with LeakSanitizer).
// fast_unwind_on_fatal=1 - use the fast (frame-pointer-based) stack unwinder
// to print error reports. V8 doesn't generate debug info for the JIT code,
// so the slow unwinder may not work properly.
#if defined(OS_LINUX)
#if defined(GOOGLE_CHROME_BUILD)
// Default AddressSanitizer options for the official build. These do not affect
@ -54,18 +57,18 @@ void _sanitizer_options_link_helper() { }
const char kAsanDefaultOptions[] =
"legacy_pthread_cond=1 malloc_context_size=5 strict_memcmp=0 "
"symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 "
"strip_path_prefix=Release/../../ ";
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
#else
// Default AddressSanitizer options for buildbots and non-official builds.
const char *kAsanDefaultOptions =
"strict_memcmp=0 symbolize=false check_printf=1 use_sigaltstack=1 "
"detect_leaks=0 strip_path_prefix=Release/../../ ";
"detect_leaks=0 strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
#endif // GOOGLE_CHROME_BUILD
#elif defined(OS_MACOSX)
const char *kAsanDefaultOptions =
"strict_memcmp=0 replace_intrin=0 check_printf=1 use_sigaltstack=1 "
"strip_path_prefix=Release/../../ ";
"strip_path_prefix=Release/../../ fast_unwind_on_fatal=1";
static const char kNaClDefaultOptions[] = "handle_segv=0";
static const char kNaClFlag[] = "--type=nacl-loader";
#endif // OS_LINUX