From c31bae28470dd22021eb5a50094d98135eb0540f Mon Sep 17 00:00:00 2001 From: John Abd-El-Malek Date: Fri, 3 Aug 2018 17:16:39 +0000 Subject: [PATCH] Fix missing dependencies with RLZ target. chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly. This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work. Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Change-Id: I85d78d25b1905c68524e0636cec3006102d17749 Reviewed-on: https://chromium-review.googlesource.com/1161610 Reviewed-by: Avi Drissman Commit-Queue: John Abd-El-Malek Cr-Original-Commit-Position: refs/heads/master@{#580579} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 22333d92d225b2abdf0a628cb811e438b3e94c88 --- check_gn_headers_whitelist.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/check_gn_headers_whitelist.txt b/check_gn_headers_whitelist.txt index d570a03f5..b655bfd1e 100644 --- a/check_gn_headers_whitelist.txt +++ b/check_gn_headers_whitelist.txt @@ -60,7 +60,6 @@ chrome/browser/media_galleries/media_file_system_context.h chrome/browser/notifications/displayed_notifications_dispatch_callback.h chrome/browser/permissions/permission_queue_controller.h chrome/browser/prefs/active_profile_pref_service.h -chrome/browser/rlz/chrome_rlz_tracker_delegate.h chrome/browser/ui/android/content_settings/subresource_filter_infobar_delegate.h chrome/browser/ui/app_icon_loader_delegate.h chrome/browser/ui/app_list/app_list_syncable_service_factory.h