Revert 84802 - Disable ICF for Valgrind/ThreadSanitizer Release builds

With ICF the linker merges identical functions into one block of assembly,
which leads to
a) wrong symbols for some functions - which is debugger/Valgrind-unfriendly
b) all ThreadSanitizer annotations end up being one function which makes TSan crazy.

Since we run release code (with -O1 -g) on Valgrind bots,
we have to disable ICF if release_valgrind_build!=0.

BUG=82114
TEST=linux_tsan trybot goes green
Review URL: http://codereview.chromium.org/6991009

TBR=timurrrr@chromium.org
Review URL: http://codereview.chromium.org/6995026

git-svn-id: http://src.chromium.org/svn/trunk/src/build@84804 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
bradnelson@google.com 2011-05-10 17:34:03 +00:00
Родитель d8e2a091c3
Коммит c3d7f4857a
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -1122,7 +1122,7 @@
# At gyp time, we test the linker for ICF support; this flag
# is then provided to us by gyp. (Currently only gold supports
# an --icf flag.)
['LINKER_SUPPORTS_ICF==1 and release_valgrind_build==0', {
['LINKER_SUPPORTS_ICF==1', {
'ldflags': [
'-Wl,--icf=safe',
]