I broke something by removing an apparently unused import that actually was used elsewhere. I addressed the issue by having the client code just call android_commands.GetAttachedDevices explicitly.
BUG=168518 Review URL: https://codereview.chromium.org/143623007 git-svn-id: http://src.chromium.org/svn/trunk/src/build@250206 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
Родитель
dca8980cb9
Коммит
c3ffd2a73d
|
@ -35,8 +35,6 @@ def CommonChecks(input_api, output_api):
|
||||||
"""Returns a path relative to presubmit directory."""
|
"""Returns a path relative to presubmit directory."""
|
||||||
return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
|
return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
|
||||||
|
|
||||||
# F0401 is issued when pylint can't import a module, but it doesn't seem to
|
|
||||||
# work correctly on our scripts.
|
|
||||||
output.extend(input_api.canned_checks.RunPylint(
|
output.extend(input_api.canned_checks.RunPylint(
|
||||||
input_api,
|
input_api,
|
||||||
output_api,
|
output_api,
|
||||||
|
|
|
@ -17,6 +17,8 @@ BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..', '..')
|
||||||
sys.path.append(BUILD_ANDROID_DIR)
|
sys.path.append(BUILD_ANDROID_DIR)
|
||||||
|
|
||||||
from pylib import android_commands
|
from pylib import android_commands
|
||||||
|
# While this isn't used in this file, it is used in some files that import it.
|
||||||
|
from pylib.android_commands import GetAttachedDevices # pylint: disable=W0611
|
||||||
|
|
||||||
|
|
||||||
class BuildDevice(object):
|
class BuildDevice(object):
|
||||||
|
|
Загрузка…
Ссылка в новой задаче