Revert 28558 because this is clearly responsible for
breaking the interactive ui tests. It just needs a clobber. It looks like 2 parts of the code don't agree on the number of buttons on the bookmark bar. Maybe because part of the code is compiled with CHROME_PERSONALIZATION = 1 while the test is compiled with CHROME_PERSONALIZATION = 0. Maybe this new gyp change broke the define propagation. This is really easy to replicate, and should also be easy to debug. Original Log: Relanding the interactive UI tests GYP factor out, as it turns out it is not responsible for breaking the interactive ui tests. Review URL: http://codereview.chromium.org/271046 git-svn-id: http://src.chromium.org/svn/trunk/src/build@28668 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This commit is contained in:
Родитель
6ba9cba998
Коммит
c457689683
3
all.gyp
3
all.gyp
|
@ -12,7 +12,6 @@
|
|||
'../app/app.gyp:*',
|
||||
'../base/base.gyp:*',
|
||||
'../chrome/chrome.gyp:*',
|
||||
'../chrome/test/interactive_ui/interactive_ui_test.gyp:*',
|
||||
'../ipc/ipc.gyp:*',
|
||||
'../media/media.gyp:*',
|
||||
'../net/net.gyp:*',
|
||||
|
@ -159,6 +158,7 @@
|
|||
'dependencies': [
|
||||
'../app/app.gyp:app_unittests',
|
||||
'../chrome/chrome.gyp:browser_tests',
|
||||
'../chrome/chrome.gyp:interactive_ui_tests',
|
||||
'../chrome/chrome.gyp:memory_test',
|
||||
'../chrome/chrome.gyp:page_cycler_tests',
|
||||
'../chrome/chrome.gyp:plugin_tests',
|
||||
|
@ -173,7 +173,6 @@
|
|||
# mini_installer_tests depends on mini_installer. This should be
|
||||
# defined in installer.gyp.
|
||||
'../chrome/installer/mini_installer.gyp:mini_installer',
|
||||
'../chrome/test/interactive_ui/interactive_ui_test.gyp:interactive_ui_tests',
|
||||
'../courgette/courgette.gyp:courgette_unittests',
|
||||
'../ipc/ipc.gyp:ipc_tests',
|
||||
'../media/media.gyp:media_unittests',
|
||||
|
|
Загрузка…
Ссылка в новой задаче