From c4ee2b6c04a1d2a5737e75c6d3c3a3af1bb22368 Mon Sep 17 00:00:00 2001 From: scottmg Date: Thu, 8 Dec 2016 09:45:07 -0800 Subject: [PATCH] Remove -r option from dump_syms invocation on Linux The -r option was originally added and used to attempt to avoid address space exhaustion on 32 bit builders. It appears to be causing missing function names in stack traces (see https://crbug.com/670533). Since we no longer build on 32 bit anyway, remove the option. R=mark@chromium.org BUG=670533,230995 Review-Url: https://codereview.chromium.org/2563663003 Cr-Original-Commit-Position: refs/heads/master@{#437277} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: fc57756e6a469a6f2df99a0b9cd0dd40f9f6b8f4 --- linux/dump_app_syms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux/dump_app_syms.py b/linux/dump_app_syms.py index c18bff776..65f76450c 100644 --- a/linux/dump_app_syms.py +++ b/linux/dump_app_syms.py @@ -23,7 +23,7 @@ outfile = sys.argv[4] if not os.path.isfile(outfile) or \ os.stat(outfile).st_mtime > os.stat(infile).st_mtime: with open(outfile, 'w') as outfileobj: - subprocess.check_call([dumpsyms, '-r', infile], stdout=outfileobj) + subprocess.check_call([dumpsyms, infile], stdout=outfileobj) if strip_binary != '0': subprocess.check_call(['strip', infile])