Revert r240528 to reapply r240460; Roll swarm_client @ f89de358c2.

$ git log aab3a62beb..f89de358c2 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2013-12-13 maruel Remove the ban on 'command' that are declared in included .isolate file.
2013-12-12 maruel Fix assert occurring on OSX due to already hardlinked files.
2013-12-11 ganetsky Create a .gitignore file and add *.pyc to it
2013-12-11 maruel Stop signalling swarming error on Windows file locking.
2013-12-11 maruel Ensure variables are decoded to unicode.
2013-12-06 maruel Rename --command-variable to --extra-variables.
2013-12-06 maruel Add real variable support and split --variable in 3 different flags.
2013-12-05 vadimsh Add 'offset' parameter to StorageApi.fetch(...) method.
2013-12-05 maruel Change log message to be clearer.
2013-12-05 vadimsh Support custom HTTP headers in net.url_open.
2013-12-03 vadimsh Remove urllib2 support.
2013-12-03 vadimsh Wait for Storage's internal threads to finish before exiting.
2013-12-03 vadimsh Fix swarming_smoke_test.py and isolateserver_test.py.

This commit is done manually, as the breakage caused by the last commit can't be
tested on the Try Server. This is because of the way
build/scripts/slave/runisolatedtest.py modifies the .isolated.state files.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/106643010

git-svn-id: http://src.chromium.org/svn/trunk/src/build@240882 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

android/pylib/gtest/setup.py

@@ -114,8 +114,8 @@ def _GenerateDepsDirUsingIsolate(suite_name):
       'remap',
       '--isolate', isolate_abs_path,
       '--isolated', isolated_abs_path,
-      '-V', 'PRODUCT_DIR=%s' % constants.GetOutDirectory(),
-      '-V', 'OS=android',
+      '--path-variable', 'PRODUCT_DIR', constants.GetOutDirectory(),
+      '--config-variable', 'OS', 'android',
       '--outdir', constants.ISOLATE_DEPS_DIR,
   ]
   assert not cmd_helper.RunCmd(isolate_cmd)

isolate.gypi

@@ -33,6 +33,9 @@
 #
 # The generated .isolated file will be:
 #   <(PRODUCT_DIR)/foo_test.isolated
+#
+# See http://dev.chromium.org/developers/testing/isolated-testing/for-swes
+# for more information.
 
 {
   'rules': [
@@ -43,7 +46,6 @@
         # Files that are known to be involved in this step.
         '<(DEPTH)/tools/swarming_client/isolate.py',
         '<(DEPTH)/tools/swarming_client/run_isolated.py',
-        '<(DEPTH)/tools/swarming_client/googletest/run_test_cases.py',
 
         # Disable file tracking by the build driver for now. This means the
         # project must have the proper build-time dependency for their runtime
@@ -66,8 +68,8 @@
         '<(test_isolation_mode)',
         # Variables should use the -V FOO=<(FOO) form so frequent values,
         # like '0' or '1', aren't stripped out by GYP.
-        '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
-        '--variable', 'OS=<(OS)',
+        '--path-variable', 'PRODUCT_DIR', '<(PRODUCT_DIR) ',
+        '--config-variable', 'OS=<(OS)',
         '--result', '<@(_outputs)',
         '--isolate', '<(RULE_INPUT_PATH)',
       ],
@@ -76,7 +78,9 @@
         ['OS=="mac"', {
           # <(mac_product_name) can contain a space, so don't use FOO=<(FOO)
           # form.
-          'action': [ '--variable', 'mac_product_name', '<(mac_product_name)' ],
+          'action': [
+            '--extra-variable', 'mac_product_name', '<(mac_product_name)',
+          ],
         }],
         ["test_isolation_outdir==''", {
           # GYP will eliminate duplicate arguments so '<(PRODUCT_DIR)' cannot